Web3 UI fixes and signer error handling

ping-browser · Jul 28, 2024 · aca2807 · aca2807
1 parent cf7c8c4
commit aca2807
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 27 deletions.
diff --git a/components/brave_rewards/resources/page/ping_doc_signer/utils/pdf_signer.tsx b/components/brave_rewards/resources/page/ping_doc_signer/utils/pdf_signer.tsx
@@ -226,13 +226,17 @@ export const signPdf = async (
 
     const toSign = buf.toString('hex')
 
-    return new Promise((resolve) => {
+    return new Promise((resolve, reject) => {
       ; (chrome as any).pkcs11.getSignature(
         hsmPath,
         pin,
         toSign,
         (sig: string) => {
-          getPkcs11ErrorHandler(sig)
+          try {
+            getPkcs11ErrorHandler(sig)
+          } catch (error) {
+            reject(error)
+          }
           let signature = Buffer.from(sig, 'hex').toString('binary')
           resolve(signature)
         }

diff --git a/components/brave_wallet/browser/brave_wallet_prefs.cc b/components/brave_wallet/browser/brave_wallet_prefs.cc
@@ -169,8 +169,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
       kDefaultSolanaWallet,
       static_cast<int>(
           brave_wallet::mojom::DefaultWallet::BraveWalletPreferExtension));
-  registry->RegisterStringPref(kDefaultBaseCurrency, "USD");
-  registry->RegisterStringPref(kDefaultBaseCryptocurrency, "BTC");
+  registry->RegisterStringPref(kDefaultBaseCurrency, "INR");
+  registry->RegisterStringPref(kDefaultBaseCryptocurrency, "SOL");
   registry->RegisterBooleanPref(kShowWalletIconOnToolbar, true);
   registry->RegisterDictionaryPref(kBraveWalletTransactions);
   registry->RegisterDictionaryPref(kBraveWalletP3AActiveWalletDict);

diff --git a/components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-overview.tsx b/components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-overview.tsx
@@ -98,7 +98,7 @@ import {
   BackgroundWatermark,
   BalanceAndLineChartWrapper
 } from './style'
-import { Column, Row, HorizontalSpace } from '../../../shared/style'
+import { Column, Row } from '../../../shared/style'
 
 // Queries
 import {
@@ -618,15 +618,15 @@ export const PortfolioOverview = () => {
                 </>
               ) : (
                 <>
-                  <LoadingSkeleton
+                  {/* <LoadingSkeleton
                     width={55}
                     height={24}
                   />
                   <HorizontalSpace space='8px' />
                   <LoadingSkeleton
                     width={55}
                     height={24}
-                  />
+                  /> */}
                 </>
               )}
             </Row>

diff --git a/components/brave_wallet_ui/options/nav-options.ts b/components/brave_wallet_ui/options/nav-options.ts
@@ -43,24 +43,24 @@ export const isValidPanelNavigationOption = (
 }
 
 export const BuySendSwapDepositOptions: NavOption[] = [
-  {
-    id: 'buy',
-    name: 'braveWalletBuy',
-    icon: 'coins-alt1',
-    route: WalletRoutes.FundWalletPageStart
-  },
+  // {
+  //   id: 'buy',
+  //   name: 'braveWalletBuy',
+  //   icon: 'coins-alt1',
+  //   route: WalletRoutes.FundWalletPageStart
+  // },
   {
     id: 'send',
     name: 'braveWalletSend',
     icon: 'send',
     route: WalletRoutes.Send
   },
-  {
-    id: 'swap',
-    name: 'braveWalletSwap',
-    icon: 'currency-exchange',
-    route: WalletRoutes.Swap
-  },
+  // {
+  //   id: 'swap',
+  //   name: 'braveWalletSwap',
+  //   icon: 'currency-exchange',
+  //   route: WalletRoutes.Swap
+  // },
   {
     id: 'deposit',
     name: 'braveWalletDepositCryptoButton',
@@ -112,12 +112,12 @@ export const NavOptions: NavOption[] = [
     icon: 'user-accounts',
     route: WalletRoutes.Accounts
   },
-  {
-    id: 'market',
-    name: 'braveWalletTopNavMarket',
-    icon: 'discover',
-    route: WalletRoutes.Market
-  }
+  // {
+  //   id: 'market',
+  //   name: 'braveWalletTopNavMarket',
+  //   icon: 'discover',
+  //   route: WalletRoutes.Market
+  // }
 ]
 
 export const AllNavOptions: NavOption[] = [

diff --git a/components/brave_wallet_ui/page/screens/shared-screen-components/tab-header/tab-header.tsx b/components/brave_wallet_ui/page/screens/shared-screen-components/tab-header/tab-header.tsx
@@ -11,7 +11,7 @@ import { useOnClickOutside } from '../../../../common/hooks/useOnClickOutside'
 // Styled Components
 import {
   HeaderWrapper,
-  BraveLogo,
+  // BraveLogo,
   SettingsButton,
   SettingsIcon,
   SettingsWrapper
@@ -50,7 +50,7 @@ export const TabHeader = (props: Props) => {
         rowHeight='full'
         verticalAlign='center'
       >
-        <BraveLogo />
+        {/* <BraveLogo /> */}
       </Row>
       {!hideHeaderMenu && (
         <SettingsWrapper ref={settingsModalRef}>