Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BM25Tokenizer to correctly handle tokenization language #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elampe-freeday
Copy link

@elampe-freeday elampe-freeday commented Sep 23, 2024

Problem

The word_tokenize function has a language parameter, which defaults to 'english'. However, when this function is called within the BM25Tokenizer, the language parameter is not passed, so it always defaults to 'english', even if self.language is set to a different value.

Solution

Added self.language to the arguments of word_tokenize in the BM25Tokenizer class.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@mjvankampen
Copy link

@acatav is this repo still maintained? Is there an alternative you would recommend switching to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants