Fix BM25Tokenizer to correctly handle tokenization language #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
word_tokenize
function has alanguage
parameter, which defaults to'english'
. However, when this function is called within theBM25Tokenizer
, thelanguage
parameter is not passed, so it always defaults to'english'
, even ifself.language
is set to a different value.Solution
Added
self.language
to the arguments ofword_tokenize
in theBM25Tokenizer
class.Type of Change
Test Plan
Describe specific steps for validating this change.