Change License to Apache 2.0 #201
Conversation
# Conflicts: # pinecone/config.py # pinecone/core/utils/__init__.py # pinecone/index.py
There was a problem hiding this comment.
Thanks for getting the LICENSE updated for the Python client!
There's a lot of formatting changes in here, I'm assuming from running black or something? If they're not necessarily needed for adding the license we may want to back them out.
I'm assuming stripping out the copyright headers is all intentional though.
Testing is failing in CI currently because there's an indentation issue in pinecone/core/client/__init__.py which needs to be resolved.
|
|
||
| """ | ||
| # flake8: noqa""" |
There was a problem hiding this comment.
I think the beginning of the comment block needs to drop to the following line. This PR is failing testing in CI due to IndentationErrors in this file, looks like:
==================================== ERRORS ====================================
__________________ ERROR collecting tests/unit/test_config.py __________________
.tox/py38/lib/python3.8/site-packages/_pytest/python.py:578: in _importtestmodule
mod = import_path(self.fspath, mode=importmode)
.tox/py38/lib/python3.8/site-packages/_pytest/pathlib.py:524: in import_path
importlib.import_module(module_name)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
:1014: in _gcd_import
???
:991: in _find_and_load
???
:975: in _find_and_load_unlocked
???
:671: in _load_unlocked
???
.tox/py38/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:170: in exec_module
exec(co, module.dict)
tests/unit/test_config.py:1: in
import pinecone
pinecone/init.py:2: in
from .config import *
pinecone/config.py:13: in
from pinecone.core.client.exceptions import ApiKeyError
E File "/home/runner/work/pinecone-python-client/pinecone-python-client/pinecone/core/client/init.py", line 4
E Pinecone API
E ^
E IndentationError: unexpected indent
Update the License to Apache 2.0.