Add usb temp compensation to weather #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdmeers
reviewed
Jun 25, 2024
There was a problem hiding this comment.
I was regularly getting relative humidities from 100-110% from this code. I think the issue was with this line
absolute_humidity = helpers.relative_to_absolute_humidity(humidity, temperature)
I think it should be
absolute_humidity = helpers.relative_to_absolute_humidity(humidity, adjusted_temperature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide the offset approach I mentioned in #134
It is based on the work done on #142 and adds the same adjustment code into the weather.py sensor reading function.
I have adjusted the rounding to happen in the return data section rather than the initial variable population to reduce rounding errors and also added some logging to allow the adjustment to be visible in the logs.
I have tested briefly and it has behaved as expected with no errors and reasonable output values. I have a separate thermometer and humidity sensor in this room and the values are now both much improved in matching these.