Fixed crash on cold RTC boot #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Do you have more details of the crash you experienced? From a cold boot the RTC does have a time (though out by 2 years), so shouldn't cause a crash when being applied to the Pico's RTC. |
|
When I unboxed my enviro urban, the dRTC kept trying to set the time on the Pico's RTC to something in 2001 and immediately crashes. This fix attempts to fetch NTP time if the dRTC is ridiculously off (as defined by an existing function; where the dRTC reports the year to be 2020) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks before writing external RTC time to Pico's time to prevent error-crash when the enviro board is booted from a cold RTC.