Add user secrets #115 #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimbrouwers
reviewed
Dec 4, 2023
| type ConfigBuilderSpec = | ||
| { AddEnvVars : bool | ||
| BasePath : string | ||
| RequiredFiles : ConfigFile list | ||
| OptionalFiles : ConfigFile list | ||
| InMemory : Map<string, string> } | ||
| InMemory : Map<string, string> | ||
| AddUserSecrets: bool} |
There was a problem hiding this comment.
Add a space here to separate the type from the bracket.
pimbrouwers
reviewed
Dec 4, 2023
| @@ -51,6 +54,9 @@ type ConfigBuilder (args : string[]) = | |||
|
|
|||
| bldr.AddCommandLine(args) |> ignore | |||
|
|
|||
| if conf.AddUserSecrets then | |||
There was a problem hiding this comment.
This should appear before env vars, I try to match the prior specified here: https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration.
pimbrouwers
reviewed
Dec 4, 2023
| @@ -101,6 +107,11 @@ type ConfigBuilder (args : string[]) = | |||
| member _.AddOptionalJsonFile (conf : ConfigBuilderSpec, filePath : string) = | |||
| { conf with OptionalFiles = (JsonFile filePath) :: conf.OptionalFiles } | |||
|
|
|||
| ///Adds optional user secrets to the ConfigurationBuilder. | |||
| [<CustomOperation("optional_user_secrets")>] | |||
There was a problem hiding this comment.
Is the non-optional brother of this omitted on purpose?
There was a problem hiding this comment.
Yes because it is generally only used in the Development environment. In the default web builder of the c# template where it sets up all the config for you it only adds optional user secrets if the env is development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to add dotnet user secrets json configuration in the configuration builder.