Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition by using fs.open and fs.fstat, also allow file descriptor to be passed #125

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Avoid race condition by using fs.open and fs.fstat, also allow file descriptor to be passed #125

wants to merge 12 commits into from

Commits on Dec 17, 2016

  1. Allow specifying file descriptor and use fs.open and fs.fstat 

    Resolves pillarjs#122
Resolves pillarjs#123
    @jcready
    jcready committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    bf94c75 View commit details
    Browse the repository at this point in the history

  2. Fix linting issues

    @jcready
    jcready committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    59c716c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2017

  1. Handle fs.close() errors

    @jcready
    jcready committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    78fd8b2 View commit details
    Browse the repository at this point in the history

  2. Adjust comment

    @jcready
    jcready committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    31e9c83 View commit details
    Browse the repository at this point in the history

  3. No need to test this twice

    @jcready
    jcready committed Jan 22, 2017
    Configuration menu
    Copy the full SHA
    7ef9e1c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2017

  1. Handle additional fs.close error

    @jcready
    jcready committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    07999c7 View commit details
    Browse the repository at this point in the history

  2. Create PartStream constructor to ensure the autoClose 

    option is respected in node.js < 0.10. Also remove the
`destroy` dependency.
    @jcready
    jcready committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    5486e0d View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2017

  1. Handle node/libuv error on windows where instead 

    of returning an error code of `EBADF` it returns
an error code of `OK` which makes zero sense
    @jcready
    jcready committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    ed3055f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2017

  1. Ensure fd is closed in the following cases: 

    1. The `res` ends before it is passed to `send().pipe()`
2. The `res` ends after pipe but before the `open` event
    @jcready
    jcready committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    ff711b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2017

  1. Fix typo, improve tests, clean up code

    @jcready
    jcready committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    26a52a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2017

  1. Merge branch ‘pillarjs/send’ into open-fd 

    # Conflicts:
#	index.js
#	test/send.js
    @jcready
    jcready committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    7b97dec View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Merge branch 'pillarjs/master' into open-fd 

    # Conflicts:
#	README.md
#	package.json
#	test/send.js
    @jcready
    jcready committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    0bd97e4 View commit details
    Browse the repository at this point in the history