Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider unit shift in split of biomass #141

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Consider unit shift in split of biomass #141

merged 2 commits into from
Nov 27, 2024

Conversation

robinhasse
Copy link
Contributor

  • rewrite of calcIOEdgeBuildings
  • new function for consistent split of biomass into modern and traditional: toolSplitBiomass
  • limits of this split are adapted to the unit shift
    • we expect more modern and less traditional biomass compared to the short period before when the unit shift was effective but not considered here

ricardarosemann
ricardarosemann approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ricardarosemann ricardarosemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another code cleaning effort (and for fixing the GDP units). One very minor comment only,

R/toolSplitBiomass.R Show resolved Hide resolved
@robinhasse robinhasse merged commit 234b8c1 into pik-piam:master Nov 27, 2024
2 checks passed
@robinhasse robinhasse deleted the splitBio branch November 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardarosemann ricardarosemann ricardarosemann approved these changes

@LaviniaBaumstark LaviniaBaumstark Awaiting requested review from LaviniaBaumstark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinhasse @ricardarosemann