Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve landing page #259

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Improve landing page #259

merged 1 commit into from
Oct 18, 2023

Conversation

asumandang
Copy link
Contributor

Issue

Evidence

image image

@asumandang asumandang requested a review from mensch72 as a code owner October 18, 2023 17:35
@asumandang
Copy link
Contributor Author

@mensch72 I'm sorry I didn't notice I wasn't able to create a PR 😰 Here's the PR for the landing page issue 🙇‍♀️

@ghost
Copy link

ghost commented Oct 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

mensch72
mensch72 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@mensch72 mensch72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about "vw" units instead of "%", and about "srcset". Thank you for teaching these bits to me!

All looks fine now, I will only later exchange some of the new text ad lib. Thank you!

@mensch72 mensch72 merged commit 857d37f into pik-gane:main Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mensch72 mensch72 mensch72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asumandang @mensch72