Creating configuration to set a default ACL for new objects #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some S3 providers (such as DigitalOcean) do not provide a bucket-wide option for "public read" for newly added items. Instead, an ACL must be set on the metadata of each
putObjectrequest into the bucket setting thex-amz-aclheader topublic-read.Here I've implemented another S3 configuration option to read in a new configuration key,
S3_DEFAULT_ACL(which would then bepublic-readfor those providers who require it), and then use it to set the header value. If it is undefined, it will act as it currently does today and not send anything.Minio translates metadata into headers, and will pass this along as a header.
Also added tests around this change, and fixed a small typing issue (the as never), which appears to be a non-issue.