-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HackRf. #53
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR! This is great.
Most of my comments are style related, where the style deviates from the style in the rest of the code. I don't have clang-format file in here yet but should add one so it's not longer something to review.
Could you rename HackRf
-> HackRF
? This is the capitalization used by GSG.
uint8_t bb_gain = 30; | ||
|
||
// Enables or disables the RF amplifier | ||
bool rf_amp_enabled = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't heard of this one. Is it some kind of AGC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 62 is for supporting the little amp package that the HackRF has internally (https://github.com/mossmann/hackrf/blob/master/doc/hardware/hackrf-one-schematic.pdf): https://www.broadcom.com/products/wireless/amplifiers/gain-block-and-drivers/mga-81563
The HackRF wiki has some documentation for the gain settings here: https://github.com/mossmann/hackrf/wiki/FAQ#making-sense-of-gain-settings
} | ||
|
||
void HackRf::process(size_t nsamples, unsigned char* buf, | ||
std::complex<float>* fo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can go on the previous line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, do you have a preferred line width? Done
aa2f9d8
to
cb3e5ae
Compare
Please take another look :) |
Is there any update on this? I've been having the same issue. |
Renaming complete HackRf -> HackRF. |
@kazaril Hey Sam, are you sure you're pointing at the right satellite? It is possible you're looking at GOES-18 which is only transmitting a HRIT carrier at this point. That is consistent with the constellation you're seeing. |
@pietern the signal is immediately locking regardless of what frequency I select. I can receive LRIT fine using the RTLSDR dongle with the same setup, but I'm wanting to get the HackRF working so that I can move on to HRIT (pretty sure the RTLSDR doesn't have the bandwidth for it) EDIT: OK, so it looks like the issue is due to HackRF having a big spike at centre frequency due to not having matched components (they had to make some sacrifices to keep the price down). I might have to write something to filter it/have a frequency offset. I wonder why @nqbit didn't have this issue, maybe just got lucky with his HRF. |
@kazaril I am now having the exact same issue as you with the large DC spike in the center causing lots of issues. Were you able to get a frequency offset working? |
@gornstein I fumbled around for a while trying to add the offset to the code but in the end just switched to Satdump as it has a DC block option built in. If you do end up getting the offset working in Goestools please let me know - I'd be very curious to hear how it performs. |
@kazaril alright thanks, I'll be sure to let you know if I get anything working! |
I have have verified that I am able to collect images with a HackRf plus a GOES SAW Bird (LNA + SAW Filter) attached to my laptop.