Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Asset Entry #46

Merged
merged 9 commits into from
Jun 26, 2020
Merged

Single Asset Entry #46

merged 9 commits into from
Jun 26, 2020

Conversation

travisdmathis
Copy link
Contributor

@travisdmathis travisdmathis commented Jun 23, 2020 •
edited
Loading

Description
Checklist
  • Linter status: 100% pass
  • Changes don't break existing behavior
  • Test coverage hasn't decreased
Testing
Refers/Fixes

Fixes: #30

Total Hours: 16

@travisdmathis travisdmathis changed the title WIP: Single Asset Entry Single Asset Entry Jun 24, 2020
MickdeGraaf
MickdeGraaf reviewed Jun 24, 2020
View reviewed changes
mainnet-test/test.ts Show resolved Hide resolved
test/pBasicSmartPool.ts Show resolved Hide resolved
MickdeGraaf
MickdeGraaf approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@MickdeGraaf MickdeGraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmvt dmvt merged commit 8861faa into development Jun 26, 2020
@dmvt dmvt deleted the feature/single-asset-entry#30 branch June 26, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickdeGraaf MickdeGraaf MickdeGraaf approved these changes

@dmvt dmvt Awaiting requested review from dmvt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Single asset join
3 participants
@travisdmathis @MickdeGraaf @dmvt