Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Single asset join #30

Closed
5 of 7 tasks
MickdeGraaf opened this issue May 21, 2020 · 3 comments · Fixed by #46
Closed
5 of 7 tasks

[Feature] Single asset join #30

MickdeGraaf opened this issue May 21, 2020 · 3 comments · Fixed by #46
Assignees
@travisdmathis
Labels
enhancement New feature or request

Comments

@MickdeGraaf
Copy link
Member

MickdeGraaf commented May 21, 2020 •
edited by travisdmathis
Loading

User Story

  • As an <audience/user>: User
  • I want to <action/task>: Add liquidity from a single asset
  • so that <outcome/goal/benefit>: So I don't have to source all the individual tokens.

Type

  • Enhancement
  • Maintenance
  • Refactor

Definition of Done

  • function joinswapExternAmountIn(address tokenIn, uint256 tokenAmountIn)
  • function joinswapPoolAmountOut(uint poolAmountOut, address tokenIn)
  • Test coverage in unit tests for above functionality
  • Test above functionality in mainnet test

Attach files or screenshots if it's helpful for this issue.

Reference implementation: https://github.com/balancer-labs/smart-pools/blob/master/crp/contracts/ConfigurableRightsPool.sol
@MickdeGraaf MickdeGraaf changed the title [Feature] Single asset join and exit [Feature] Single asset join May 22, 2020
@dmvt
Copy link
Contributor

dmvt commented Jun 1, 2020

https://forum.piedao.org/t/bounty-program-votes/118/2
PieDAO governance has voted to approve this issue for a bounty:
Approved Scope: 8 - 16 hours (2795.2 - 5590.4 $DOUGH)
Contributor: @travisdmathis

@travisdmathis travisdmathis added the enhancement New feature or request label Jun 23, 2020
This was referenced Jun 23, 2020
Merged
Merged
@dmvt dmvt closed this as completed in #46 Jun 26, 2020
@travisdmathis travisdmathis reopened this Jun 28, 2020
@travisdmathis
Copy link
Contributor

Leaving as done until paid out

@MickdeGraaf MickdeGraaf mentioned this issue Jul 28, 2020
Merged
3 tasks
@MickdeGraaf
Copy link
Member Author

Implemented in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travisdmathis travisdmathis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Single Asset Entry pie-dao/pie-smart-pools
3 participants
@dmvt @MickdeGraaf @travisdmathis