Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection handlers and packaging fixes #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Selection handlers and packaging fixes #47

wants to merge 4 commits into from

Conversation

Wunsz
Copy link

@Wunsz Wunsz commented Nov 9, 2020

  1. Merge with Added handlers for selection #23 which results in adding the following event listeners:
  • onSelectionConfirmed: (rect: OpenSeadragon.Rect) => any
  • onSelectionCanceled: (v: false) => any
  • onSelectionChange: (rect: OpenSeadragon.Rect) => any
  • onSelectionToggled: (arg: {enabled: boolean}) => any
  1. Also added documentation regarding these callbacks to README.md
  2. Bumped & fixed gulp to the newest version.
  3. Added require statement for Openseadragon for package managers

jetic83 and others added 4 commits June 19, 2017 11:04
@jetic83
Added handlers for selection
28b5a70 
Removed handler onSelection, added handlers onSelectionConfirmed (replaces onSelection), onSelectionCanceled, onSelectionChange, onSelectionToggled.
@Wunsz
Merge remote-tracking branch 'jetic83/patch-1'
968b34f
@Wunsz
Bump and fix gulp version
e4a071d
@Wunsz
Add openseadragon require and update readme
57430f6
@stanf0rd
Copy link

stanf0rd commented Jan 21, 2021 •
edited
Loading

I'm upvoting this PR, it is very useful for our company
@dthornley can you review and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wunsz @stanf0rd @jetic83