Fix: openseadragon 3.0 API #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In openseadragon 3.0 viewer.buttons was renamed to viewer.buttonGroup openseadragon/openseadragon@0ede899
arthur-flam
referenced
this pull request
in openseadragon/openseadragon
Jan 20, 2022
This makes it more clear what we're testing for or calling methods on, vs. assigning to this.buttons in both the useGroup true and false cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In openseadragon 3.0
viewer.buttonswas renamed toviewer.buttonGroup, breaking the plugin:openseadragon/openseadragon@0ede899
For backward-compat you may want to allow any of the 2 APIs... The MR is mainly there to tell you about this, feel free to fix in a different commit.
Have a good day and thanks a lot for this useful plugin!