Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement base code for kakao oauth #4

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: implement base code for kakao oauth #4

merged 4 commits into from
Apr 23, 2024

Conversation

jw-r
Copy link
Member

@jw-r jw-r commented Apr 19, 2024

개요

oauth 작업을 위한 기본 코드 베이스를 작성했습니다.

세부 내용

  • 간단한 로그인 화면 구현
  • oauth handler 구현

관련 링크

@jw-r jw-r requested a review from woo-jk April 19, 2024 15:07
@jw-r jw-r self-assigned this Apr 19, 2024
@jw-r jw-r changed the title feat: implement base code for oauth feat: implement base code for oauth Apr 23, 2024
@jw-r jw-r changed the title feat: implement base code for oauth feat: implement base code for kakao oauth Apr 23, 2024
Copy link
Member

@woo-jk woo-jk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 next auth에 관심있는데 시간 되실 때 설명 타임 한 번 부탁드립니다 ㅎ

사소한 코멘트만 남겨놨으니 바로 approve 할게요~

},

session: ({ session, token }) => {
if (token && token.sub) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(token?.sub) {

},
})

export { handler as GET, handler as POST }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 보니깐 EOL(End of Line) 설정이 안되어있는 것 같아요. 다른 PR들도 동일합니다!

프리티어에 EOL 설정 넣어주시면 감사하겠습니다~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL 설정 되어있는 것 확인했습니다!
깃허브에서는 이러한 개행 문자를 시각적으로 표시하지 않는다고 합니다!

실제로 EOL이 적용되어있지 않으면 깃허브에서 다음과 같이 경고를 해줍니다!
image

@jw-r jw-r merged commit 688025c into main Apr 23, 2024
5 checks passed
@jw-r jw-r deleted the feat-oauth branch April 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants