feat: document search #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-search # Conflicts: # src/requests/document/hooks.ts
…t-search # Conflicts: # src/requests/document/hooks.ts
jw-r
approved these changes
Dec 11, 2024
| setIsSearchFocused(false) | ||
| return | ||
| } else { | ||
| router.push('/document') |
There was a problem hiding this comment.
router.back이 아닌 document로 보내는 이유가 있을까요?
There was a problem hiding this comment.
router.back이 아닌 document로 보내는 이유가 있을까요?
앗 안그래도 저도 통합검색 구현하면서 잘못된 부분들이 좀 있길래 수정했는데ㅎㅎ 이 부분도 정우님 말씀처럼 router.back으로 통합검색 쪽에서 수정했습니다!
| > | ||
| <div tabIndex={-1} className="relative grow"> | ||
| <header className="flex-center relative right-1/2 z-20 h-[56px] w-full max-w-mobile grow translate-x-1/2 bg-background-base-01 px-[16px] text-subtitle2-medium"> | ||
| <form onSubmit={onSubmit} tabIndex={-1} className="relative grow"> | ||
| <Input |
| @@ -22,7 +25,8 @@ const SearchItem = ({ | |||
| lastItem, | |||
| }: Props) => { | |||
| return ( | |||
| <div | |||
| <Link | |||
| href={documentId ? '/document/' + documentId : '#'} | |||
There was a problem hiding this comment.
Suggested change
| href={documentId ? '/document/' + documentId : '#'} | |
| href={documentId ? `/document/${documentId}` : '#'} |
Comment on lines
+33
to
+35
| const searchResults = [...(data?.documents ?? []), ...(data?.quizzes ?? [])] as Partial< | ||
| Document.SearchedDocument & Document.SearchedQuiz | ||
| >[] |
There was a problem hiding this comment.
우왕 검색 결과를 이렇게 통합하니까 좋네요👍
생각할수록 엄청난 구조입니다... 퀴즈 결과와 문서 결과를 화면에 같은 양식으로 보여줘야 하는...😂
…t-search # Conflicts: # src/types/schema.d.ts
rabyeoljji
added a commit
to rabyeoljji/pick-toss-next
that referenced
this pull request
Dec 11, 2024
* feat: document-search * fix: merge * feat: use-recent-searches hook * fix: 스토리지에 저장되는 데이터 구조 간단하게 수정 * fix: localstorage * refactor: markdown processor * fix: api 변경 + usePreviousPath hook 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
zod와 react-hook-form 을 이용해서 검색을 구현하고 싶었으나
왜인지 해당 로직으로 submit시, local storage가 초기화되는 현상이 발생
우선 해당 도구를 이용한 유효성 검사가 필수적인 부분은 아니라 판단되어 (빈 검색어만 필터링) 없이 구현
(+ 추가 고민 지점)
세부 내용
관련 링크