refactor: type + axios interceptor #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw-r
approved these changes
Dec 9, 2024
| @@ -1,5 +1,5 @@ | |||
| import RandomQuizView from '@/features/quiz/screen/random-quiz-view' | |||
| import { getBookmarkedCollections } from '@/requests/collection' | |||
| import { getBookmarkedCollections } from '@/requests/collection/client' | |||
There was a problem hiding this comment.
아 해당 함수가 hook에서도 사용되고 page에서도 사용되고 있어서 일단 client에만 뒀었는데 그런 애들은 그럼 일괄적으로 server파일에 똑같이 만들어서 import 해두겠습니다
| const AuthContext = createContext<string | null>(null) | ||
|
|
||
| /** 사용할 때 useToken */ | ||
| export const AuthProvider = ({ children }: { children: React.ReactNode }) => { |
There was a problem hiding this comment.
getSession으로 session으로 호출할 수 있다면 auth provider는 불필요하지 않나용?
getSession은 이전 버전에서 사용하던 건데 현재 버전에서도 사용가능하군요 👍
There was a problem hiding this comment.
아 사용은 가능한데 말씀하신 것처럼 이전 버전용이고 그래서 provider를 이용해서 하는 게 더 나은 방법 같기도 해서 나중에 추가했어요ㅎㅎㅠㅠㅠ provider를 이용한 코드로 전체적으로 수정하고 getSession을 사용을 안하는 코드로 변경해서 업데이트하려고 합니다...!
| type Record = QuizRecord | ||
| type Result = UpdateQuizResultPayload['quizzes'][number] | ||
|
|
||
| type Type = Exclude<DeepRequired<components['schemas']['QuizDto']['quizType']>, undefined> |
There was a problem hiding this comment.
흠 일단 옵셔널을 deeprequired로 바꾸다보니까 유니언 타입에서 undefined가 같이 껴서 반환이 돼서 이걸 최대한 없애보고자 이렇게 작성해보긴 했는데 다른 좋은 방법은 없을까 고민중입니다ㅠㅠ
rabyeoljji
added a commit
to rabyeoljji/pick-toss-next
that referenced
this pull request
Dec 9, 2024
* refactor: type + axios interceptor * fix: cspell * feat: zustand * refactor: 주석 추가 * fix: type * fix: token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
우선 인터셉터 쪽에서 getSession을 사용할 수 있다는 걸 알게되어 이렇게 구현했습니다세부 내용
관련 링크