Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update user name #289

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat: update user name #289

merged 2 commits into from
Dec 3, 2024

Conversation

jw-r
Copy link
Member

@jw-r jw-r commented Dec 2, 2024

개요

Form 컴포넌트의 사용과 validation. Dialog + Form이 어떻게 동작해야하는지에 대한 요구사항 등이 포함되어있습니다.
shadcn form

세부 내용

관련 링크

@jw-r jw-r requested a review from rabyeoljji December 2, 2024 14:01
@jw-r jw-r self-assigned this Dec 2, 2024
Copy link
Contributor

@rabyeoljji rabyeoljji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다 정우님ㅎㅎ👍

@@ -31,26 +75,43 @@ const SetNameDialog = ({ userName }: { userName: string }) => {
<DialogContent
displayCloseButton={false}
className="h-fit w-[280px] rounded-[16px] bg-background-base-01 p-[24px] pb-[32px]"
onPointerDownOutside={(e) => {
if (isPending) {
e.preventDefault()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 생각 못했는데 이런식의 처리도 필요하겠군요👍

@jw-r jw-r merged commit 90135c7 into develop Dec 3, 2024
5 of 6 checks passed
@jw-r jw-r deleted the feat-update-user-name branch December 3, 2024 02:04
rabyeoljji added a commit to rabyeoljji/pick-toss-next that referenced this pull request Dec 3, 2024
* feat: 사용자 profile api 요청 함수 및 훅 구현

* feat: change user name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants