feat: quiz loading + intro #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- api 연동은 아직 구현 안되어있습니다
…t-quiz # Conflicts: # src/app/(routes)/quiz/[id]/page.tsx # src/app/(routes)/quiz/page.tsx # src/requests/quiz/index.tsx
…t-quiz # Conflicts: # src/app/(routes)/quiz/[id]/page.tsx
jw-r
force-pushed
the
develop
branch
4 times, most recently
from
f771f5c to
28122e6
Compare
…t-quiz # Conflicts: # src/requests/index.ts
jw-r
approved these changes
Dec 3, 2024
| searchParams: { | ||
| tab?: 'document-content' | 'quiz' | ||
| } | ||
| } | ||
|
|
||
| const DocumentDetailPage = ({ searchParams }: Props) => { | ||
| const DocumentDetailPage = async ({ params, searchParams }: Props) => { | ||
| const id = params.id | ||
| const tab = searchParams.tab ?? 'document-content' | ||
| const activeTab = ['document-content', 'quiz'].includes(tab) ? tab : 'document-content' |
There was a problem hiding this comment.
이 방식은 너무 좋지만 탭이 바뀔 때 해당 url이 브라우저 history에 남지 않도록 하면 좋을 것 같아요!
There was a problem hiding this comment.
이 방식은 너무 좋지만 탭이 바뀔 때 해당 url이 브라우저 history에 남지 않도록 하면 좋을 것 같아요!
오 그렇네요! router.replace()를 사용하는 쪽으로 코드를 수정하려고 합니다ㅎㅎ
…t-quiz # Conflicts: # src/requests/collection/index.ts # src/shared/configs/endpoint.ts # src/types/collection.d.ts
rabyeoljji
added a commit
to rabyeoljji/pick-toss-next
that referenced
this pull request
Dec 4, 2024
* fix: quiz - 변경된 사항들 반영해 코드 수정 * feat: 오답 터뜨리기 ui / interaction 구현 - api 연동은 아직 구현 안되어있습니다 * feat: 다음 작업 주석처리 * feat: 오답 터뜨리기 접근 시 로딩 추가 * fix: css 수정 * fix: 애니메이션 수정 * refactor: 코드리뷰 반영 + bombPositions 컨벤션 통일 * feat: quiz loading + intro * fix: "use client" 추가 * fix: client * fix: debugging * fix: debugging + refactoring * fix: build error * fix: build error * fix: format error * fix: api 변경 * fix: api 변경 * fix: build error * fix: build error * fix: build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
퀴즈 도입 부분 1차 구현해봤습니다 (보완 필요)지금 코드는 레이아웃 컴포넌트에서 useRef를 사용하는 식으로 작성되어있는데 이 부분은 수정할 예정입니다
수정 계획은 인트로 처리까지 별도 클라이언트 컴포넌트를 만들어서 페이지에서 import해서 사용하려고 합니다!
(수정)
api 변동 있을 예정
[ 현재 동작하는 기능 ]
세부 내용
관련 링크