refactor: document type #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-document # Conflicts: # src/types/document.d.ts
jw-r
approved these changes
Nov 23, 2024
src/types/document.d.ts
Outdated
Comment on lines
170
to
172
| type Item = DocumentDetailItem | ||
| type List = DocumentListItem[] | ||
| type ListItem = DocumentListItem |
There was a problem hiding this comment.
너무 좋은데요?
네이밍만 조금 더 직관적으로 바뀌면 좋을 것 같아요!
예를들면 아래와 같은..?
Document.DetailItem
Document.ItemInList
Document.List
rabyeoljji
added a commit
to rabyeoljji/pick-toss-next
that referenced
this pull request
Nov 24, 2024
* feat: document card check * feat: query client for storybook * fix: merge and fix error * feat: directory id에 따른 documents 가져오기 + queries 적용 * fix: 불필요한 코드 삭제 * fix: build error * fix: import * fix: storybook * fix: expend buttons bug * fix: document markdown debugging * refactor: document type * refactor: 타입명 수정 * fix: modify document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
음... document type이 리스트를 불러올 때랑 디테일을 불러올 때 필드가 몇 개 달라서 아예 분리해봤습니다.
정우님 의견을 여쭤보고 싶습니다!
세부 내용
관련 링크