-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: storage main page UI 구현 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
코맨트만 확인 부탁드려요~
<div className="mx-auto w-full max-w-[1440px] px-20 pb-8"> | ||
<HeaderLayout /> | ||
{children} | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 좋네요!
다만 이렇게 작성되면 children 컴포넌트에서 h-full
을 적용했을 때 pb-8
크기만큼 스크롤이 생기는 문제가 발생할 것 같습니다.
children container에서 pb-8
을 적용하는 등의 방식을 사용해야 할 것 같은데 다른 해결책이 있을까요?
<div className="mx-auto w-full max-w-[1440px] px-20 pb-8"> | |
<HeaderLayout /> | |
{children} | |
</div> | |
<div className="mx-auto w-full max-w-[1440px] px-20"> | |
<HeaderLayout /> | |
{children} | |
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그러네요. 저 패딩 값은 레이아웃이 아닌 페이지 컴포넌트(혹은 하위 레이아웃 컴포넌트)에서 알아서 처리해주는게 더 적절해보입니다!
개요
세부 내용
- 공부창고 메인 페이지 UI 구현 - 각 페이지 layout을 (routes)의 layout으로 통합관련 링크