Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage main page UI 구현 #10

Merged
merged 4 commits into from
Apr 30, 2024
Merged

feat: storage main page UI 구현 #10

merged 4 commits into from
Apr 30, 2024

Conversation

woo-jk
Copy link
Member

@woo-jk woo-jk commented Apr 30, 2024

개요

  • 공부창고 메인 페이지 UI 구현

세부 내용

스크린샷 2024-05-01 오전 3 02 07 - 공부창고 메인 페이지 UI 구현 - 각 페이지 layout을 (routes)의 layout으로 통합

관련 링크

@woo-jk woo-jk requested a review from jw-r April 30, 2024 18:04
Copy link
Member

@jw-r jw-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

코맨트만 확인 부탁드려요~

Comment on lines +18 to +21
<div className="mx-auto w-full max-w-[1440px] px-20 pb-8">
<HeaderLayout />
{children}
</div>
Copy link
Member

@jw-r jw-r Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋네요!
다만 이렇게 작성되면 children 컴포넌트에서 h-full을 적용했을 때 pb-8 크기만큼 스크롤이 생기는 문제가 발생할 것 같습니다.

children container에서 pb-8을 적용하는 등의 방식을 사용해야 할 것 같은데 다른 해결책이 있을까요?

Suggested change
<div className="mx-auto w-full max-w-[1440px] px-20 pb-8">
<HeaderLayout />
{children}
</div>
<div className="mx-auto w-full max-w-[1440px] px-20">
<HeaderLayout />
{children}
</div>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그러네요. 저 패딩 값은 레이아웃이 아닌 페이지 컴포넌트(혹은 하위 레이아웃 컴포넌트)에서 알아서 처리해주는게 더 적절해보입니다!

@jw-r jw-r self-requested a review April 30, 2024 18:34
@jw-r jw-r merged commit 7cc09cf into main Apr 30, 2024
5 checks passed
@jw-r jw-r deleted the feat-storage-main-ui branch April 30, 2024 18:35
@jw-r jw-r assigned jw-r and woo-jk and unassigned jw-r Apr 30, 2024
@woo-jk woo-jk restored the feat-storage-main-ui branch May 1, 2024 00:44
@woo-jk woo-jk deleted the feat-storage-main-ui branch May 1, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants