Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultReleaseType to be None in autorc file #8

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Aug 29, 2024

Closes #

Problem with a plugin of auto:

Auto found a commit that looked like a conventional commit, and because the default for unknown labels is to "skip" release, it applied a "skip" mark and computed (correctly) the release as no increment:
https://github.com/physiopy/physutils/actions/runs/10497563830/job/29080679203#step:4:611

Proposed Changes

  • Add"defaultReleaseType": "none", to the .autorc file

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@RayStick RayStick changed the title add defaultReleaseType add defaultReleaseType to be None Aug 29, 2024
@RayStick RayStick changed the title add defaultReleaseType to be None add defaultReleaseType to be None in autorc file Aug 29, 2024
@RayStick
Copy link
Member Author

@smoia I think this will work but how best to test it?

@RayStick RayStick requested review from smoia and maestroque August 29, 2024 10:16
@@ -9,6 +9,7 @@
"repo": "physutils",
"name": "Stefano Moia",
"email": "[email protected]",
"defaultReleaseType": "none",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to go into the conventional commit plugin instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right! Let me take a closer look

@maestroque maestroque removed their request for review September 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants