Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .zenodo.json file to include multiple affiliations #33

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Sep 2, 2024

Closes #

Update .zeondo.json file to include multiple affiliations
As discussed on slack with @smoia

Proposed Changes

  • Rachael and Stefano now have multiple affiliations listed

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@github-actions github-actions bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Sep 2, 2024
@RayStick RayStick requested a review from smoia September 2, 2024 14:24
@smoia
Copy link
Member

smoia commented Sep 3, 2024

I guess it's correct, thank you @RayStick !
Unfortunately we can't really test until the next version trigger. Let's see what happens then!

@smoia smoia marked this pull request as ready for review September 3, 2024 05:33
@smoia smoia merged commit 85ad788 into master Sep 3, 2024
4 of 6 checks passed
@RayStick RayStick deleted the zenodo branch September 3, 2024 07:12
@RayStick
Copy link
Member Author

@smoia this seems to have worked 🥳 yeah?
https://zenodo.org/records/13356552
Shall I implement the same multiple affiliations (for you and me) for other repos?

@smoia
Copy link
Member

smoia commented Oct 24, 2024

Unfortunately it didn't - we're already at release 0.8.1 but Zenodo is not keeping up. I wrote to them to ask why, but with no avail.

Do you want to try to contact them again? that'd help. Alternatively, I saw that they are now working with CFF files, if you want to give it a try?

@smoia
Copy link
Member

smoia commented Oct 24, 2024

I was looking at the dev API here:
https://developers.zenodo.org/#github

We can also try to see if correcting the file would trigger Zenodo correctly again.

Would you be able to try with physioQC, to start?

@RayStick
Copy link
Member Author

Ohhhh I did not look closely enough. I see now 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants