-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lag application for negative lags #36
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Actually, @tsalo, it's difficult for me to figure out which changes you wanted to stay - can you resolve the conflicts with master, please? |
Sorry for the delay @smoia. I'll give that a try now. |
I ended up having to change a few things. Lags were removed from Also, lags in |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 47.04% 47.04%
=======================================
Files 7 7
Lines 321 321
=======================================
Hits 151 151
Misses 170 170
|
Closes #35.
This PR corrects the calculation of negative lags.
Proposed Changes
lags
parameter inrv
function.numpy.int
(deprecated) withint
.Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review