Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend dynamic referencing for data.frame #72

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

mariev
Copy link
Collaborator

@mariev mariev commented Mar 18, 2021

allows for use case described here: #71 (comment)

This is a rather brute-force implementation. A more robust approach would be to dispatch the gsub call as a generic function, but not sure if we want that much overhead.

@mariev mariev requested a review from thebioengineer March 18, 2021 16:18
@thebioengineer
Copy link
Collaborator

I think it would make sense to break out into methods to keep the code a bit clearer/cleaner of what is going on

@mariev mariev merged commit 585de77 into develop Mar 18, 2021
@mariev mariev deleted the hotfix-dynamic-referencing-df branch March 18, 2021 18:47
@mariev
Copy link
Collaborator Author

mariev commented Mar 18, 2021

@thebioengineer opened #73 to capture discussion from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants