Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.4.0 #203

Merged
merged 66 commits into from
Nov 4, 2021
Merged

Release 0.4.0 #203

merged 66 commits into from
Nov 4, 2021

Conversation

thebioengineer
Copy link
Collaborator

This marks release v0.4.0

Notable updates:

  • Packet creation for validation external to packages with accompanying vignette
  • new vignette on image snapshot comparisons
  • bug fix to prevent file overwriting when running vt_use_* for a pre-existing file
  • Cheat sheets
  • Logo
  • Improved test coverage

Ellis Hughes and others added 30 commits July 20, 2021 08:13
Add initial cheatsheet
64a5a0a
Initial addition of validation packets vignette and code
d3f6584
argument corrections and cleaning up the external resources vignette
1d81e19
Add valtools hex to package. Thanks @MayaGans
3ab4a7a
Add cheatsheets to .Rbuildignore & to readme
30b67b9
convert cheatsheet pdf to png, update readme to reflect that
d5a70da
some wording and spacing updates to the packet vignette
5092f7e
Add a packet template - similar to standard but removes the expectati…
c163714 
…on of function authors.
improve config test coverage
0b58993
correct packet creation function & test cleanup
bcf68ca
set covr nocov
e9f39c3
@thebioengineer
Move cheatsheets to man/figures
e459695
@thebioengineer
update .Rbuildignore cheatsheet paths
ced5d77
Merge pull request #180 from phuse-org/add_cheatsheet_flow
0aca7db 
Add hex and cheat sheet flow
Add to roxygen_copy tests
b61a4ef
example of figure comparisons
8bb4dd5
spelling and make reference to location saved within validation infra
6adc9ff
Update tests and remove cases where coverage tag has no ":" as allowable
a959267
Add missed space and closing parenthesis for test
44b0d96
Merge pull request #181 from phuse-org/validation_packet
0a47f42 
Validation packets
Merge pull request #188 from phuse-org/malformed_coverage_tags
8df1104 
Update tests and remove cases where coverage tag has no ":" as allowable
Merge branch 'develop' into test_coverage_improvements
8eeb9bf
@mariev
remove extra space, affects sorting
eb601e2
@mariev
ordering at export
376132e
@mariev
update tests
f0c9269
@mariev
remove dplyr dependency in tests
7076710
@mariev
lingering dplyr
b83e3bd
@mariev
Merge pull request #189 from phuse-org/hotfix-coverage-matrix
ac3a4e8 
Hotfix coverage matrix
@mariev
develop should be ahead of main
225a389
@mariev
Merge pull request #192 from phuse-org/hotfix-versioning
0c56533 
develop should be ahead of main
@mariev
Copy link
Collaborator

mariev commented Oct 18, 2021

@thebioengineer can you look at #204 ?

elimillera
elimillera approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@elimillera elimillera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @thebioengineer LGTM!

@thebioengineer
Copy link
Collaborator Author

blocked by #210 - once merged in, this is GTG

mariev
mariev requested changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@mariev mariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! can we resolve #211 and pull in work from #210 as well?

@mariev
Copy link
Collaborator

mariev commented Nov 2, 2021

closes #202

@thebioengineer
Copy link
Collaborator Author

@mariev - no problem. I'll ping once that is done

looks good! can we resolve #211 and pull in work from #210 as well?

@thebioengineer
Copy link
Collaborator Author

resolved #211 - @mariev , please approve once the tests pass

@thebioengineer thebioengineer requested a review from mariev November 4, 2021 13:49
@thebioengineer thebioengineer merged commit 5d9a003 into main Nov 4, 2021
@thebioengineer thebioengineer deleted the release_0.4.0 branch November 4, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elimillera elimillera elimillera approved these changes

@mariev mariev mariev approved these changes

Assignees
No one assigned
Labels
v0.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebioengineer @mariev @elimillera