Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toc, more details, call out dynamic referencing as an advanced to… #135

Merged
merged 11 commits into from
May 10, 2021

Conversation

thebioengineer
Copy link
Collaborator

…pic.

@thebioengineer thebioengineer requested a review from mariev May 8, 2021 00:23
Copy link
Collaborator

@mariev mariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thebioengineer thebioengineer requested a review from mariev May 10, 2021 18:31
Copy link
Collaborator

@mariev mariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering what audience we expect to target with this vignette? I like having minimal examples to help conceptualize the intro to these new concepts, but the emphasis on validate-while-developing means that the concepts are not easily abstracted to the other modes. It may not be immediately obvious to some the other modes make {valtools} immediately useful for validation outside of development 😬

Looking ahead, will there be a separate vignette for each mode? if so, what can we do now to be repetitive about shared concepts such as requirements, etc. without having to re-implement text at a low level?

edit to add: It looks like all my comments are questions of audience accessibility and saving us future rework, so definitely speaks to quality of the examples and overall pacing 🏆

vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Outdated Show resolved Hide resolved
vignettes/starting-validated-package.Rmd Show resolved Hide resolved
@thebioengineer thebioengineer merged commit 0b23828 into develop May 10, 2021
@thebioengineer thebioengineer deleted the example_validation_project branch May 10, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants