Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail URL checker if one or more bad URLs are found #4

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fail URL checker if one or more bad URLs are found #4

merged 3 commits into from
Dec 18, 2023

Conversation

cicdguy
Copy link
Collaborator

@cicdguy cicdguy commented Dec 15, 2023

Otherwise urlchecker only prints bad URLs, and doesn't exit with a non-zero exit code.

@cicdguy cicdguy self-assigned this Dec 15, 2023
@cicdguy cicdguy requested review from epijim and bms63 December 15, 2023 15:20
epijim
epijim approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@epijim epijim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dinakar!

r-lib/urlchecker#42

@epijim epijim merged commit 279ed38 into main Dec 18, 2023
4 checks passed
@epijim epijim deleted the fix/fail-urlchecker-workflow branch December 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epijim epijim epijim approved these changes

@bms63 bms63 Awaiting requested review from bms63

Assignees

@cicdguy cicdguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdguy @epijim