Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the requirements in the
slog.Handler
documentation and the tests inslogtest
and added some testing to your console handler tests. This is how I found the zerotime issue that you just pushed.Everything else seems fine. Half of what I did was to add comments to tests detailing why they are important.
I'm not sure you'll want these additions, but you're welcome to them. The only reason I can think of to add them is the chance that the stuff I did add might catch some future error.
I won't be offended if you just ignore this. 😉
BTW, thanks for doing this!