Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required #4

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Required #4

merged 3 commits into from
Jan 13, 2024

Conversation

madkins23
Copy link

I went through the requirements in the slog.Handler documentation and the tests in slogtest and added some testing to your console handler tests. This is how I found the zerotime issue that you just pushed.

Everything else seems fine. Half of what I did was to add comments to tests detailing why they are important.

I'm not sure you'll want these additions, but you're welcome to them. The only reason I can think of to add them is the chance that the stuff I did add might catch some future error.

I won't be offended if you just ignore this. 😉

BTW, thanks for doing this!

@phsym
Copy link
Owner

phsym commented Jan 12, 2024

That's very cool, thanks a lot for this. I'm running out of time for today, but I'll review very soon. There are high chances that I'll merge this. There's no reason to accept more tests

@phsym phsym merged commit d4a3eec into phsym:main Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants