Add support for Themes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use HandlerOptions in encoder to avoid repeating code - HandlerOptions should not be a pointer as it can't be modified from the outside - Encoder doesn't have internal state, so no need to be a pointer - Default Theme tries to follow as close as possible Zerolog's Console theme
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
This is described in Handler.Handle method: If an Attr's key and value are both the zero value, ignore the Attr.
|
@phsym do you have an ETA for when you can review this? |
|
Hi @injeniero I reviewed it already and it looks good to me. I just want to give it a try before merging. Give me a few days as I'm a bit busy on other stuff |
phsym
approved these changes
Nov 21, 2023
|
@injeniero Thanks a lot. Works like a charm |
|
Released in v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with it, I found the color scheme you used was making it really hard to read long messages because they would have the same color for the Timestamp and AttrValue. So I thought it would be great to make it configurable.
Other changes in this PR: