Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure MacOS support by tests #539

Draft
wants to merge 12 commits into
base: php8
Choose a base branch
from
Draft

Ensure MacOS support by tests #539

wants to merge 12 commits into from
+106 −30

Conversation

JoshuaBehrens
Copy link
Contributor

These are either necessary steps or helpful changes to let this run on MacOS. I have further changes to do so this is just a draft

@JoshuaBehrens
Copy link
Contributor Author

This error is weird

v8js/v8js/v8js_object_export.cc:678:9: error: ‘php_strtolower’ was not declared in this scope; did you mean ‘php_strtok_r’?

This method exists for over 25 years and the file is included :D
https://github.com/php/php-src/blame/2a794e8205363e0ef5aea8800c8f04b2b381a03a/ext/standard/php_string.h

@JoshuaBehrens JoshuaBehrens force-pushed the feature/build-on-macos-brew branch 2 times, most recently from 8c62c3e to 214e00e Compare October 24, 2024 22:30
@JoshuaBehrens JoshuaBehrens force-pushed the feature/build-on-macos-brew branch 2 times, most recently from 44f89cc to 7627555 Compare October 25, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshuaBehrens