Ignore ContainerBagInterface in ContainerInterfaceUnknownServiceRule

phpstan · Aug 18, 2021 · 2c24080 · 2c24080
1 parent fe5f5d8
commit 2c24080
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php b/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php
@@ -55,6 +55,11 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$argType = $scope->getType($node->var);
+		$isContainerBagType = (new ObjectType('Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface'))->isSuperTypeOf($argType);
+		if ($isContainerBagType->yes()) {
+			return [];
+		}
+
 		$isControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\Controller'))->isSuperTypeOf($argType);
 		$isAbstractControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\AbstractController'))->isSuperTypeOf($argType);
 		$isContainerType = (new ObjectType('Symfony\Component\DependencyInjection\ContainerInterface'))->isSuperTypeOf($argType);

diff --git a/tests/Rules/Symfony/ContainerInterfaceUnknownServiceRuleTest.php b/tests/Rules/Symfony/ContainerInterfaceUnknownServiceRuleTest.php
@@ -68,4 +68,18 @@ public function testGetPrivateServiceInAbstractController(): void
 		);
 	}
 
+	public function testGetPrivateServiceInLegacyServiceSubscriber(): void
+	{
+		if (!interface_exists('Symfony\Contracts\Service\ServiceSubscriberInterface')) {
+			self::markTestSkipped('The test needs Symfony\Contracts\Service\ServiceSubscriberInterface class.');
+		}
+
+		$this->analyse(
+			[
+				__DIR__ . '/ExampleServiceSubscriber.php',
+			],
+			[]
+		);
+	}
+
 }
diff --git a/tests/Rules/Symfony/ExampleServiceSubscriber.php b/tests/Rules/Symfony/ExampleServiceSubscriber.php
@@ -12,6 +12,13 @@ public function privateService(): void
 		$this->get('private');
 	}
 
+	public function containerParameter(): void
+	{
+		/** @var \Symfony\Component\DependencyInjection\ParameterBag\ContainerBag $containerBag */
+		$containerBag = doFoo();
+		$containerBag->get('parameter_name');
+	}
+
 	/**
 	 * @return string[]
 	 */