Support tagged unions in array_merge
#3770
Merged
+103
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
commented
Jan 4, 2025
herndlm
force-pushed
the
array-merge-tagged-unions
branch
from
1ee5bfc to
8952033
Compare
herndlm
commented
Jan 5, 2025
|
Ondrejs law strikes again: get rid of |
|
This looks like it could be relevant on 1.12.x, can you try that? Thanks! |
herndlm
force-pushed
the
array-merge-tagged-unions
branch
from
77c0c0c to
ad54a20
Compare
herndlm
force-pushed
the
array-merge-tagged-unions
branch
from
ad54a20 to
be81e3e
Compare
|
This pull request has been marked as ready for review. |
done, you should be able to upmerge this just fine |
|
Thank you! |
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lucky find combined with some cleanups :)
Closes phpstan/phpstan#7857
Closes phpstan/phpstan#8632
Closes phpstan/phpstan#9559