Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantenimiento 2024-09-09 (Versión 3.3.2) #84

Merged
merged 6 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
run: phpstan analyse --no-progress --verbose

tests:
name: Tests on PHP ${{ matrix.php-versions }}
name: Tests on PHP ${{ matrix.php-version }}
runs-on: "ubuntu-latest"
strategy:
matrix:
Expand Down
10 changes: 5 additions & 5 deletions .phive/phars.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<phive xmlns="https://phar.io/phive">
<phar name="php-cs-fixer" version="^3.57.2" installed="3.57.2" location="./tools/php-cs-fixer" copy="false"/>
<phar name="phpcs" version="^3.10.0" installed="3.10.0" location="./tools/phpcs" copy="false"/>
<phar name="phpcbf" version="^3.10.0" installed="3.10.0" location="./tools/phpcbf" copy="false"/>
<phar name="phpstan" version="^1.11.11" installed="1.11.1" location="./tools/phpstan" copy="false"/>
<phar name="composer-normalize" version="^2.42.0" installed="2.42.0" location="./tools/composer-normalize" copy="false"/>
<phar name="php-cs-fixer" version="^3.64.0" installed="3.64.0" location="./tools/php-cs-fixer" copy="false"/>
<phar name="phpcs" version="^3.10.2" installed="3.10.2" location="./tools/phpcs" copy="false"/>
<phar name="phpcbf" version="^3.10.2" installed="3.10.2" location="./tools/phpcbf" copy="false"/>
<phar name="phpstan" version="^1.12.3" installed="1.12.3" location="./tools/phpstan" copy="false"/>
<phar name="composer-normalize" version="^2.43.0" installed="2.43.0" location="./tools/composer-normalize" copy="false"/>
</phive>
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2019 - 2023 PhpCfdi https://www.phpcfdi.com/
Copyright (c) 2019 - 2024 PhpCfdi https://www.phpcfdi.com/

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
8 changes: 8 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ Usamos [Versionado Semántico 2.0.0](SEMVER.md) por lo que puedes usar esta libr

## Cambios aún no liberados en una versión

## Versión 3.3.2 2024-09-09

- PHPStan encontró una comparación superflua que fue eliminada para corregir el proceso de integración continua.
- Se agregan comentarios a clases *Null* para mejorar la manentibilidad.
- Se actualiza el año del archivo de licencia a 2024.
- Se corrige la variable `php-versions` por `php-version` en el flujo de trabajo `tests`.
- Se actualizan las herramientas de desarrollo.

## Versión 3.3.1 2024-05-22

- PHPStan encontró un problema en una especificación de tipo en un método de prueba,
Expand Down
2 changes: 1 addition & 1 deletion src/Internal/MetaRefreshInspector.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function obtainUrl(string $html, string $baseUri): string
return '';
}

$url = trim($matches['url'] ?? '');
$url = trim($matches['url']);
if ('' === $url) {
return '';
}
Expand Down
4 changes: 4 additions & 0 deletions src/NullMetadataMessageHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,21 @@ class NullMetadataMessageHandler implements Contracts\MetadataMessageHandler
{
public function resolved(DateTimeImmutable $since, DateTimeImmutable $until, int $count): void
{
// null object, do nothing
}

public function date(DateTimeImmutable $since, DateTimeImmutable $until, int $count): void
{
// null object, do nothing
}

public function divide(DateTimeImmutable $since, DateTimeImmutable $until): void
{
// null object, do nothing
}

public function maximum(DateTimeImmutable $moment): void
{
// null object, do nothing
}
}