Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow #38

Closed
wants to merge 2 commits into from
Closed

Update CI workflow #38

wants to merge 2 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 22, 2024

We

  • update action/checkout to v4
  • upgrade cmb69/setup-php-sdk to php/setup-php-sdk
  • add PHP 8.1 to 8.3 to the Windows matrix

We

* update action/checkout to v4
* upgrade cmb69/setup-php-sdk to php/setup-php-sdk
* add PHP 8.1 to 8.3 to the Windows matrix
* run on windows-2019 for now
@cmb69
Copy link
Member Author

cmb69 commented Jul 22, 2024

Note that this is basically a stripped down alternative to PR #37, which does only the minimally required updates, while the other PR also extends the matrix with NTS builds and uploads build artifacts.

@cmb69 cmb69 marked this pull request as draft July 22, 2024 11:42
@cmb69 cmb69 force-pushed the cmb/update-ci branch 10 times, most recently from 0b757f6 to 3b05e67 Compare July 22, 2024 14:17
@cmb69
Copy link
Member Author

cmb69 commented Jul 22, 2024

Note that I have changed this PR back to draft due to php/php-src#8787 (comment), and the currently implemented workaround in this PR is insufficient. PR #37 likely has the same problem.

@cmb69
Copy link
Member Author

cmb69 commented Aug 27, 2024

Closing in favor of #39.

@cmb69 cmb69 closed this Aug 27, 2024
@cmb69 cmb69 deleted the cmb/update-ci branch August 27, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant