release 1.2.5

CHANGELOG.md

@@ -1,3 +1,10 @@
+### 1.2.5 (2016-04-12)
+
+#### Bug Fixes
+
+* attempt to fix elements in header bar (which are not centered vertically) on iOS [#110](https://github.com/quark-dev/Phonon-Framework/issues/110)
+* TapElement start/move when clientX/clientY is 0 throws js error [#119](https://github.com/quark-dev/Phonon-Framework/issues/119)
+
 ### 1.2.4 (2016-04-01)
 
 #### Bug Fixes

dist/css/phonon-base.css

@@ -486,6 +486,7 @@ button {
   color: #fff;
   height: 52px;
   line-height: 52px;
+  vertical-align: middle;
 }
 .header-bar .center .title {
   margin: 0 auto;
@@ -510,6 +511,7 @@ button {
   padding: 0 12px;
   height: 52px;
   line-height: 52px;
+  vertical-align: middle;
   color: #fff;
   background-color: transparent;
   border: none;

dist/css/phonon.css

@@ -486,6 +486,7 @@ button {
   color: #fff;
   height: 52px;
   line-height: 52px;
+  vertical-align: middle;
 }
 .header-bar .center .title {
   margin: 0 auto;
@@ -510,6 +511,7 @@ button {
   padding: 0 12px;
   height: 52px;
   line-height: 52px;
+  vertical-align: middle;
   color: #fff;
   background-color: transparent;
   border: none;

dist/js/components/popovers.js

@@ -96,7 +96,7 @@
     var target = evt.target, trigger = findTrigger(target);
 
     if (trigger.target) {
-      
+
       var popover = document.querySelector('#'+trigger.id);
 
       if(popover) {
@@ -204,7 +204,7 @@
         popover.style.top = rect.top + 'px';
         popover.style.left = rect.left + 'px';
       }
-      
+
       if(!popover.classList.contains('active')) {
         popover.classList.add('active');
       }
@@ -253,7 +253,7 @@
       }
     };
   };
-  
+
   window.phonon = phonon;
 
   if(typeof exports === 'object') {
@@ -262,4 +262,4 @@
     define(function() { return phonon.popover });
   }
 
-}(typeof window !== 'undefined' ? window : this, window.phonon || {}));
+}(typeof window !== 'undefined' ? window : this, window.phonon || {}));

dist/js/phonon-core.js

@@ -478,14 +478,14 @@ phonon.event = (function () {
 
             this.moved = false;
 
-            this.startX = e.clientX || e.touches[0].clientX;
-            this.startY = e.clientY || e.touches[0].clientY;
+            this.startX = (e.touches ? e.touches[0].clientX : e.clientX);
+            this.startY = (e.touches ? e.touches[0].clientY : e.clientY);
         };
 
         TapElement.prototype.move = function(e) {
 
-			var moveX = e.clientX || e.touches[0].clientX;
-            var moveY = e.clientY || e.touches[0].clientY;
+			var moveX = (e.touches ? e.touches[0].clientX : e.clientX);
+            var moveY = (e.touches ? e.touches[0].clientY : e.clientY);
 
             //if finger moves more than 10px flag to cancel
             if (Math.abs(moveX - this.startX) > 10 || Math.abs(moveY - this.startY) > 10) {

dist/js/phonon.js

@@ -478,14 +478,14 @@ phonon.event = (function () {
 
             this.moved = false;
 
-            this.startX = e.clientX || e.touches[0].clientX;
-            this.startY = e.clientY || e.touches[0].clientY;
+            this.startX = (e.touches ? e.touches[0].clientX : e.clientX);
+            this.startY = (e.touches ? e.touches[0].clientY : e.clientY);
         };
 
         TapElement.prototype.move = function(e) {
 
-			var moveX = e.clientX || e.touches[0].clientX;
-            var moveY = e.clientY || e.touches[0].clientY;
+			var moveX = (e.touches ? e.touches[0].clientX : e.clientX);
+            var moveY = (e.touches ? e.touches[0].clientY : e.clientY);
 
             //if finger moves more than 10px flag to cancel
             if (Math.abs(moveX - this.startX) > 10 || Math.abs(moveY - this.startY) > 10) {
@@ -3637,7 +3637,7 @@ phonon.tagManager = (function () {
     var target = evt.target, trigger = findTrigger(target);
 
     if (trigger.target) {
-      
+
       var popover = document.querySelector('#'+trigger.id);
 
       if(popover) {
@@ -3745,7 +3745,7 @@ phonon.tagManager = (function () {
         popover.style.top = rect.top + 'px';
         popover.style.left = rect.left + 'px';
       }
-      
+
       if(!popover.classList.contains('active')) {
         popover.classList.add('active');
       }
@@ -3794,7 +3794,7 @@ phonon.tagManager = (function () {
       }
     };
   };
-  
+
   window.phonon = phonon;
 
   if(typeof exports === 'object') {
@@ -3804,6 +3804,7 @@ phonon.tagManager = (function () {
   }
 
 }(typeof window !== 'undefined' ? window : this, window.phonon || {}));
+
 /* ========================================================================
  * Phonon: preloaders.js v0.0.5
  * http://phonon.quarkdev.com

src/js/ui/popovers.js

@@ -96,7 +96,7 @@
     var target = evt.target, trigger = findTrigger(target);
 
     if (trigger.target) {
-      
+
       var popover = document.querySelector('#'+trigger.id);
 
       if(popover) {
@@ -204,7 +204,7 @@
         popover.style.top = rect.top + 'px';
         popover.style.left = rect.left + 'px';
       }
-      
+
       if(!popover.classList.contains('active')) {
         popover.classList.add('active');
       }
@@ -253,7 +253,7 @@
       }
     };
   };
-  
+
   window.phonon = phonon;
 
   if(typeof exports === 'object') {
@@ -262,4 +262,4 @@
     define(function() { return phonon.popover });
   }
 
-}(typeof window !== 'undefined' ? window : this, window.phonon || {}));
+}(typeof window !== 'undefined' ? window : this, window.phonon || {}));

src/stylus/base/header-bars.styl

@@ -35,6 +35,7 @@
     color header-text-color
     height header-height
     line-height header-height
+    vertical-align middle
 
   .center
     .title
@@ -60,6 +61,7 @@
     padding 0 button-padding
     height header-height - header-border-bottom-height
     line-height header-height
+    vertical-align middle
     color header-text-color
     background-color transparent
     border none