-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to replicate state immediately during normal shutdown #190
Merged
chrismccord
merged 6 commits into
phoenixframework:main
from
nathanl:shutdown_technique
Sep 27, 2024
Merged
Add ability to replicate state immediately during normal shutdown #190
chrismccord
merged 6 commits into
phoenixframework:main
from
nathanl:shutdown_technique
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 26, 2024
nathanl
force-pushed
the
shutdown_technique
branch
from
September 27, 2024 15:52
9938a5f
to
8f37d1f
Compare
@josevalim updated PR |
nathanl
changed the title
Show how to replicate state immediately during normal shutdown
Add ability to replicate state immediately during normal shutdown
Sep 27, 2024
josevalim
reviewed
Sep 27, 2024
josevalim
reviewed
Sep 27, 2024
josevalim
reviewed
Sep 27, 2024
josevalim
reviewed
Sep 27, 2024
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
nathanl
commented
Sep 27, 2024
nathanl
commented
Sep 27, 2024
nathanl
commented
Sep 27, 2024
❤️❤️❤️🐥🔥 |
Hat tip to Jason Axelson for chiming in that, like me, he was doing something like this in his app: https://felt.com/blog/startup-and-shutdown-for-phoenix-applications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to replicate state immediately during normal shutdown via new option