Allow Title Bar to be Hidden

phitattoo · Sep 7, 2020 · 10dfeb8 · 10dfeb8
1 parent dafaa3b
commit 10dfeb8
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 12 deletions.
diff --git a/spec/main-process/atom-window.test.js b/spec/main-process/atom-window.test.js
@@ -152,7 +152,6 @@ describe('AtomWindow', function() {
         });
         assert.isUndefined(w1.options.titleBarStyle);
       });
-
       it('sets frame to "false" for a hidden title bar on non-spec windows', function() {
         app.config['core.titleBar'] = 'hidden';
 
@@ -168,15 +167,19 @@ describe('AtomWindow', function() {
         assert.isUndefined(w1.options.frame);
       });
     } else {
-      it('ignores title bar style settings', function() {
-        for (const value of ['custom', 'custom-inset', 'hidden']) {
-          app.config['core.titleBar'] = value;
-          const { browserWindow } = new AtomWindow(app, service, {
-            browserWindowConstructor: StubBrowserWindow
-          });
-          assert.isUndefined(browserWindow.options.titleBarStyle);
-          assert.isUndefined(browserWindow.options.frame);
-        }
+      it('sets frame to "false" for a hidden title bar on non-spec windows', function() {
+        app.config['core.titleBar'] = 'hidden';
+
+        const { browserWindow: w0 } = new AtomWindow(app, service, {
+          browserWindowConstructor: StubBrowserWindow
+        });
+        assert.isFalse(w0.options.frame);
+
+        const { browserWindow: w1 } = new AtomWindow(app, service, {
+          browserWindowConstructor: StubBrowserWindow,
+          isSpec: true
+        });
+        assert.isUndefined(w1.options.frame);
       });
     }
 

diff --git a/src/config-schema.js b/src/config-schema.js
@@ -46,6 +46,13 @@ const configSchema = {
         description:
           'List of names of installed packages which are not loaded at startup.'
       },
+      titleBar: {
+        type: 'string',
+        default: 'native',
+        enum: ['native', 'hidden'],
+        description:
+          'Experimental:  The title bar can  be completely `hidden`.<br>This setting will require a relaunch of Atom to take effect.'
+      },
       versionPinnedPackages: {
         type: 'array',
         default: [],
@@ -637,7 +644,6 @@ if (process.platform === 'darwin') {
     description:
       'Experimental: A `custom` title bar adapts to theme colors. Choosing `custom-inset` adds a bit more padding. The title bar can also be completely `hidden`.<br>Note: Switching to a custom or hidden title bar will compromise some functionality.<br>This setting will require a relaunch of Atom to take effect.'
   };
-
   configSchema.core.properties.simpleFullScreenWindows = {
     type: 'boolean',
     default: false,

diff --git a/src/main-process/atom-window.js b/src/main-process/atom-window.js
@@ -388,7 +388,6 @@ module.exports = class AtomWindow extends EventEmitter {
   shouldHideTitleBar() {
     return (
       !this.isSpec &&
-      process.platform === 'darwin' &&
       this.atomApplication.config.get('core.titleBar') === 'hidden'
     );
   }