Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent GitHub at mentions in quoted release notes #684

Merged

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jan 6, 2025

🚀 Hey, I have created a Pull Request

Description of changes

Replace instances of @... to [at]... to prevent GitHub from mentioning users that contributed fixes of automated extension updates

Closes #679

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Replace instances of @... to [at]... to prevent GitHub from mentioning users that contributed fixes of automated extension updates

Closes #679
@rjaegers rjaegers requested a review from a team as a code owner January 6, 2025 11:55
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:644d3918e69d06d3cdcc38f9775b5c31c393f367508f5b1ba4cc6fd152d3cf73

OS/Platform Previous Size Current Size Delta
linux/amd64 454.99M 454.99M 0.00 (+0.00%)
linux/arm64 593.18M 593.18M 0.00 (+0.00%)

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.08s
✅ DOCKERFILE hadolint 2 0 0.51s
✅ GHERKIN gherkin-lint 2 0 0.86s
✅ JSON npm-package-json-lint yes no 0.34s
✅ JSON prettier 15 1 0 0.5s
✅ JSON v8r 14 0 11.93s
✅ MARKDOWN markdownlint 8 0 0 0.73s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.2s
✅ REPOSITORY checkov yes no 16.14s
✅ REPOSITORY gitleaks yes no 0.25s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.64s
✅ REPOSITORY secretlint yes no 0.98s
✅ REPOSITORY syft yes no 1.2s
✅ REPOSITORY trivy yes no 5.27s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 6.52s
✅ SPELL lychee 57 0 1.56s
✅ YAML prettier 21 0 0 0.64s
✅ YAML v8r 21 0 12.21s
✅ YAML yamllint 21 0 0.39s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 17s ⏱️ -1s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 71f2881. ± Comparison against base commit 32879be.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:cd3ec0d1c5f6c93d7d68f5b19cae7955b560aea4446e3b244a3327b4f2e1a5ca

OS/Platform Previous Size Current Size Delta
linux/amd64 644.55M 644.91M 367.81K (+0.06%)
linux/arm64 636.02M 636.37M 359.08K (+0.06%)

@rjaegers rjaegers added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 1e65a95 Jan 6, 2025
23 checks passed
@rjaegers rjaegers deleted the feature/prevent-github-at-mentions-in-quoted-release-notes branch January 6, 2025 13:58
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Pull Request Report (#684)

Static measures

Description Value
Number of added lines 5
Number of deleted lines 1
Number of changed files 1
Number of commits 2
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 2 Hours
Time that was spend on the branch before the PR was created 1.2 Min
Time that was spend on the branch before the PR was merged 2.1 Hours
Time to merge after last review 1.9 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 20.2 Min
Total time spend in last status check run on PR 7.3 Min

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🎉 Hooray! The changes in this pull request went live with the release of v5.5.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The quoted release notes are inadvertently pinging people
2 participants