Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating some PICS custom changes #57

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

andersonvcv
Copy link

@andersonvcv andersonvcv commented Dec 4, 2024

Description

Isolating PICS custom changes

Motivation and Context

It's hard to understand what are our custom changes and what is from OAuth2-Proxy main repo

How Has This Been Tested?

Created a local container image of the oauth-proxy from this PR and integrated it with Reporting locally.

  • run in the root of this repo
    • docker buildx build -t oauth-local .
  • Updated FROM statement in pics/src/services/Oauth2Proxy/Dockerfile to
    • FROM oauth-local

The following flows were checked:

  • Login
  • Audit logs
  • Logout

Checklist:

  • Isolating some dunction in separated files
  • Creating a folder for Pics packages

@andersonvcv andersonvcv self-assigned this Dec 4, 2024
@andersonvcv andersonvcv changed the title Isolating PICS custom changes Isolating some PICS custom changes Dec 6, 2024
@andersonvcv andersonvcv marked this pull request as ready for review December 6, 2024 19:43
@andersonvcv andersonvcv requested a review from a team as a code owner December 6, 2024 19:43
pkg/apis/options/legacy_options.go Show resolved Hide resolved
providers/oidc.go Show resolved Hide resolved
@andersonvcv andersonvcv merged commit fb0723e into pics Dec 9, 2024
3 checks passed
@andersonvcv andersonvcv deleted the anderson/pics-isolate-custom-changes branch December 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants