Merge pull request #594 from adri09070/debugger-class-side-cleaning

Debugger class side cleaning
pharo-spec · Sep 29, 2023 · 3450bbf · 3450bbf
2 parents d952aee + db8e28f
commit 3450bbf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 31 deletions.
diff --git a/src/NewTools-Debugger-Tests/StDebugger.extension.st b/src/NewTools-Debugger-Tests/StDebugger.extension.st
@@ -1,5 +1,12 @@
 Extension { #name : 'StDebugger' }
 
+{ #category : '*NewTools-Debugger-Tests' }
+StDebugger class >> activatedDebuggerExtensions [
+
+	^ self extensionToolsClasses select: [ :extension |
+		  extension showInDebugger ]
+]
+
 { #category : '*NewTools-Debugger-Tests' }
 StDebugger >> inspector [
 

diff --git a/src/NewTools-Debugger/StDebugger.class.st b/src/NewTools-Debugger/StDebugger.class.st
@@ -91,21 +91,13 @@ Class {
 	],
 	#classVars : [
 		'EnableStackColoring',
-		'ErrorRecursion',
 		'FastTDD'
 	],
 	#category : 'NewTools-Debugger-View',
 	#package : 'NewTools-Debugger',
 	#tag : 'View'
 }
 
-{ #category : 'accessing' }
-StDebugger class >> activatedDebuggerExtensions [
-
-	^ self extensionToolsClasses select: [ :extension |
-		  extension showInDebugger ]
-]
-
 { #category : 'commands' }
 StDebugger class >> buildCommandsGroupWith: stDebuggerInstance forRoot: rootCommandGroup [
 
@@ -125,8 +117,9 @@ StDebugger class >> buildCommandsGroupWith: stDebuggerInstance forRoot: rootComm
 
 { #category : 'utilities' }
 StDebugger class >> closeAllDebuggers [
+
 	<script>
-	StDebugger allInstancesDo: [ :dbg | dbg close ]
+	self allInstancesDo: [ :dbg | dbg close ]
 ]
 
 { #category : 'instance creation' }
@@ -172,12 +165,12 @@ StDebugger class >> extensionToolsClasses [
 		  extensionClass isOnlyForTests ]
 ]
 
-{ #category : 'settings' }
+{ #category : 'accessing' }
 StDebugger class >> fastTDD [
 	^FastTDD ifNil:[FastTDD := false]
 ]
 
-{ #category : 'settings' }
+{ #category : 'accessing' }
 StDebugger class >> fastTDD: aBoolean [
 
 	FastTDD := aBoolean
@@ -204,8 +197,7 @@ StDebugger class >> hasAnyActivatedExtension: extensionsClasses [
 
 { #category : 'class initialization' }
 StDebugger class >> initialize [ 
-	self flag: 'Error recursion is used only here?'.
-	ErrorRecursion := false.
+
 	EnableStackColoring := true
 ]
 
@@ -223,18 +215,6 @@ StDebugger class >> openOn: aDebugSession withFullView: aBool andNotification: a
 	^ debugger
 ]
 
-{ #category : 'accessing' }
-StDebugger class >> sessionClass [
-	self flag: 'Should be replaced by Sindarin - should even be removed in that case!'.
-	^ DebugSession
-]
-
-{ #category : 'accessing' }
-StDebugger class >> spanNewSessionFrom: anotherSession [
-	self flag: 'Where is that used? 2019-06-28'.
-	^ anotherSession spanNewSession
-]
-
 { #category : 'settings' }
 StDebugger class >> stackColoringSettingOn: aBuilder [
 
@@ -254,12 +234,6 @@ StDebugger class >> taskbarIconName [
 	^#smallDebug
 ]
 
-{ #category : 'updating - widgets' }
-StDebugger class >> updateBlockFor: aDebugger [
-
-	^ [ aDebugger updateStep ]
-]
-
 { #category : 'tools registry' }
 StDebugger class >> usesExtensions [