Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite to show progress bar running tests #17355

Open
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from

Conversation

bouraqadi
Copy link
Contributor

No description provided.

Copy link

request-info bot commented Nov 9, 2024

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@bouraqadi
Copy link
Contributor Author

The code is straightforward

TestSuite >> #runWith: aBlock
	self setUp.
	[
	self shuffledTests 
		do: [ :each |
			aBlock value: each.
			self announceTest: each.
			self changed: each ] 
		displayingProgress: [: currentTest | currentTest className] 
	] ensure: [ self tearDown ]

@Ducasse
Copy link
Member

Ducasse commented Nov 9, 2024

Noury I was wondering if we should not do something else: introduce a runWithProgress: because with your changes any runWith: is impacted.

@bouraqadi
Copy link
Contributor Author

bouraqadi commented Nov 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants