Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BracedCollection ready for review and integration #14845

Closed
wants to merge 3 commits into from
Closed

BracedCollection ready for review and integration #14845

wants to merge 3 commits into from

Conversation

Ducasse
Copy link
Member

@Ducasse Ducasse commented Oct 1, 2023

  • Added support for broken situation
  • now semanticAnalyzer is doing something
  • fix the completion to at least not bark
  • couple more tests Ready for reviews
  • introduced a specific method withAllForBrace: so that other candidates can just redefine this method if needed.
    Please review

- now semanticAnalyzer is doing something
- fix the completion to at least not bark
- couple more tests
Ready for reviews
@jecisc
Copy link
Member

jecisc commented Oct 2, 2023

Instance of RBParseErrorNode did not understand #binding
RBParseErrorNode(Object)>>doesNotUnderstand: #binding
OCASTTranslator>>visitLiteralCollectionNode:
RBLiteralCollectionNode>>acceptVisitor:
OCASTTranslator(RBProgramNodeVisitor)>>visitNode:
OCASTTranslator>>visitNode:
[:each |
		self visitNode: each] in OCASTTranslator>>emitMessageNode: in Block: [:each |...
OrderedCollection>>do:
OCASTTranslator>>emitMessageNode:

@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Oct 2, 2023
@Ducasse
Copy link
Member Author

Ducasse commented Oct 2, 2023

This is strange that it crashed again on the same because we can now recompile the complete image.

@jecisc jecisc removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Oct 2, 2023
@jecisc
Copy link
Member

jecisc commented Oct 10, 2023

Related pheps: pharo-project/pheps#22

@Ducasse
Copy link
Member Author

Ducasse commented Nov 12, 2023

I prefer not to extend the parser for the sake of it. So I will close my PR and extension proposal.
I think that the parser extension is only good if we can get a real gain such as not creating the array but I do not see how it would be possible.

@Ducasse Ducasse closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants