Add test case for baseline_timepoints in derive_blfl function
#95
Task list completed / task-list-completed
succeeded
Sep 25, 2024 in 0s
14 / 14 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
Modify the test case to cover the usage of baseline_timepoints. |
Incomplete |
| Add different examples for the function | Incomplete |
| Place Closes #<insert_issue_number> into the beginning of your Pull z | |
| Request Title (Use Edit button in top-right if you need to update) | Completed |
| Code is formatted according to the | |
| tidyverse style guide. Run | |
styler::style_file() to style R and Rmd files |
Completed |
| Updated relevant unit tests or have written new unit tests, which should | |
| consider realistic data scenarios and edge cases, e.g. empty datasets, errors, | |
| boundary cases etc. - See | |
| Unit Test Guide | Completed |
| If you removed/replaced any function and/or function parameters, did you | |
| fully follow the | |
| deprecation guidance? | Completed |
| Update to all relevant roxygen headers and examples, including keywords | |
| and families. Refer to the | |
| categorization of functions to tag appropriate keyword/family. | Completed |
Run devtools::document() so all .Rd files in the man folder and the |
|
NAMESPACE file in the project root are updated appropriately |
Completed |
| Address any updates needed for vignettes and/or templates | Completed |
Update NEWS.md if the changes pertain to a user-facing function (i.e. it |
|
has an @export tag) or documentation aimed at users (rather than developers) |
Completed |
Build oak site pkgdown::build_site() and check that all affected |
|
| examples are displayed correctly and that all new functions occur on the "Reference" page. | Completed |
Address or fix all lintr warnings and errors - lintr::lint_package() |
Completed |
Run R CMD check locally and address all errors and warnings - devtools::check() |
Completed |
| Link the issue in the Development Section on the right hand side. | Completed |
| Address all merge conflicts and resolve appropriately | Completed |
| Pat yourself on the back for a job well done! Much love to your accomplishment! | Completed |
ISO 8601 formatted dates are being used as character and not as date-times on their own right. This means that date and time comparisons are being done lexicographically, which I find dangerous (even though I understand the measures taken at dtc_datepart() and dtc_timepart() to make sure the format is comparable). |
Incomplete |
Is the setting of <unspecified> something that is part of the SDTM standard? |
Incomplete |
Replace rbind() with dplyr's equivalent |
Incomplete |
Replace dplyr::arrange_at() with arrange() as the former is superseded. |
Incomplete |
Replace the pattern get(domain_prefixed_names["tpt"]) by idiomatic rlang alternatives, e.g. !!rlang::sym(...) or {{...}}. |
Incomplete |
| ISO 8601 formatted dates are being used as character and not as date-times on their own right. This means that date and time comparisons are being done lexicographically, which I find dangerous (even though I understand the measures taken at dtc_datepart() and dtc_timepart() to make sure the format is comparable). | |
| Confirmed that ISO 8601 will be applied to date time variables before blfl derivation, so comparing in lexicographic order should be fine. I will add code in there to check the format and give message | Incomplete |
| Is the setting of something that is part of the SDTM standard? | |
| This is not SDTM standard, but we fill in the value to make sure VISIT does not have blank values. | Incomplete |
ISO 8601 formatted dates are being used as character and not as date-times on their own right. This means that date and time comparisons are being done lexicographically, which I find dangerous (even though I understand the measures taken at dtc_datepart() and dtc_timepart() to make sure the format is comparable). |
Incomplete |
Is the setting of <unspecified> something that is part of the SDTM standard? |
Incomplete |
Replace rbind() with dplyr's equivalent |
Incomplete |
Replace dplyr::arrange_at() with arrange() as the former is superseded. |
Incomplete |
Replace the pattern get(domain_prefixed_names["tpt"]) by idiomatic rlang alternatives, e.g. !!rlang::sym(...) or {{...}}. |
Incomplete |
Loading