-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace base messages with rlang and cli #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @galachad:
- Can't we stick with
cli::cli_abort/warn/inform()
all across instead ofrlang::abort/warn/inform()
? Just for consistency. - The S3 registration of
mutate.cnd_df
is not a mistake by you (it's a commit by me made earlier to this PR, see d6e3d92. So think commit d0873ac should be reverted. - Locally, I still get the testthat snapshot blfl related issues when I run
devtools::check()
on this PR, so I am guessing that the CI/CD checking this PR is not using the latest admiraldev version, is it?
Hi @ramiromagno The snapshot issue is fixed #73 or #75 we do not yet decide whether we are merged. The different in the message was introduced in admiraldev v1.1.0 package. For export of Let's use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Close #78
Request Title (Use Edit button in top-right if you need to update)
tidyverse style guide. Run
styler::style_file()
to style R and Rmd filesconsider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide
fully follow the
deprecation guidance?
and families. Refer to the
categorization of functions to tag appropriate keyword/family.
devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. ithas an
@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affectedexamples are displayed correctly and that all new functions occur on the "Reference" page.
lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()