Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace base messages with rlang and cli #76

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Conversation

galachad
Copy link
Member

@galachad galachad commented Jul 26, 2024

  • Replace base message with rlang
  • Move vignette to package space
  • Adds missing metadata in vignette

Close #78

  • Place Closes #<insert_issue_number> into the beginning of your Pull z
    Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the
    tidyverse style guide. Run
    styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should
    consider realistic data scenarios and edge cases, e.g. empty datasets, errors,
    boundary cases etc. - See
    Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you
    fully follow the
    deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords
    and families. Refer to the
    categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the
    NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it
    has an @export tag) or documentation aimed at users (rather than developers)
  • Build oak site pkgdown::build_site() and check that all affected
    examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Jul 26, 2024

Code Coverage

Package Line Rate Health
sdtm.oak 93%
Summary 93% (953 / 1021)

Copy link
Collaborator

@ramiromagno ramiromagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @galachad:

  • Can't we stick with cli::cli_abort/warn/inform() all across instead of rlang::abort/warn/inform()? Just for consistency.
  • The S3 registration of mutate.cnd_df is not a mistake by you (it's a commit by me made earlier to this PR, see d6e3d92. So think commit d0873ac should be reverted.
  • Locally, I still get the testthat snapshot blfl related issues when I run devtools::check() on this PR, so I am guessing that the CI/CD checking this PR is not using the latest admiraldev version, is it?

@galachad
Copy link
Member Author

galachad commented Jul 29, 2024

Hi @ramiromagno

The snapshot issue is fixed #73 or #75 we do not yet decide whether we are merged.

The different in the message was introduced in admiraldev v1.1.0 package.

For export of mutate.cnd_df: thanks was pointing that out, I was thinking that I exported that by the mistake.

Let's use cli everywhere for the errors and messages.

@galachad galachad requested a review from ramiromagno July 29, 2024 14:36
Copy link
Collaborator

@ramiromagno ramiromagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@galachad galachad merged commit b2cad05 into main Jul 30, 2024
12 of 13 checks passed
@galachad galachad deleted the smaller-fix-cran-release branch July 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Replace base messages with rlang and cli
3 participants