Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tidyselect issue #72

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix tidyselect issue #72

merged 3 commits into from
Jul 24, 2024

Conversation

galachad
Copy link
Member

Close #68

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
sdtm.oak 88% ✔
Summary 88% (902 / 1022) ✔

@ramiromagno
Copy link
Collaborator

Oh man... I can't be believe this was it... the .before / .after are also using tidyselection...?

I can confirm that devtools::check() no longer raises those tidyselect warnings. Well spotted Adam!

@ramiromagno
Register cnd_df method for mutate
d6e3d92 
I noticed that were missing this `S3method(mutate,cnd_df)` in the NAMESPACE. I think we should use @export always now on methods and roxygen2 will do the right thing: see https://www.tidyverse.org/blog/2024/01/roxygen2-7-3-0/.
ramiromagno
ramiromagno approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@ramiromagno ramiromagno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks Adam for spotting the issue with .after. Your change, together with my following change on the S3 registration makes it ready for merging.

edgar-manukyan
edgar-manukyan approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@edgar-manukyan edgar-manukyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job @galachad 🙏

@galachad galachad merged commit a6e52d5 into main Jul 24, 2024
15 checks passed
@galachad galachad deleted the fix-tidyselect-issue branch July 24, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgar-manukyan edgar-manukyan edgar-manukyan approved these changes

@ramiromagno ramiromagno ramiromagno approved these changes

@rammprasad rammprasad Awaiting requested review from rammprasad

Assignees
No one assigned
Labels
None yet
Projects
sdtm.oak R package
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings due to _Using an external vector in selections was deprecated in tidyselect 1.1.0._
3 participants
@galachad @ramiromagno @edgar-manukyan