0046 assign datetime #52

ramiromagno · 2024-05-14T23:12:36Z

Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide
to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the devel branch until you have checked off each task.

[x ] Place Closes #<insert_issue_number> into the beginning of your Pull z
Request Title (Use Edit button in top-right if you need to update)
[ x] Code is formatted according to the
tidyverse style guide. Run
styler::style_file() to style R and Rmd files
[x ] Updated relevant unit tests or have written new unit tests, which should
consider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide
[x ] If you removed/replaced any function and/or function parameters, did you
fully follow the
deprecation guidance?
[x ] Update to all relevant roxygen headers and examples, including keywords
and families. Refer to the
categorization of functions to tag appropriate keyword/family.
[x ] Run devtools::document() so all .Rd files in the man folder and the
NAMESPACE file in the project root are updated appropriately
[ x] Address any updates needed for vignettes and/or templates
[x ] Update NEWS.md if the changes pertain to a user-facing function (i.e. it
has an @export tag) or documentation aimed at users (rather than developers)
[ x] Build oak site pkgdown::build_site() and check that all affected
examples are displayed correctly and that all new functions occur on the "Reference" page.
[x ] Address or fix all lintr warnings and errors - lintr::lint_package()
[x ] Run R CMD check locally and address all errors and warnings - devtools::check()
[x ] Link the issue in the Development Section on the right hand side.
[ x] Address all merge conflicts and resolve appropriately
[x ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Update `hardcode_no_ct()` by allowing the rewriting of the `target_sdtm_variable` variable to preserve `NA`

* hardcode_no_ct algorithm code changes * harcode_ct working as expected * assign_ct and assign_no_ct works great. * address review comments

Merge branch 'main' into 0040_hardcode_no_ct # Conflicts: # DESCRIPTION # NAMESPACE # inst/WORDLIST

- Adds three new user facing ct-related functions: `read_ct_example()`, `ct_example()` and `read_ct()` - Provides a ct example file in inst/ct/

… calling functions

… into 0040_hardcode_no_ct

As it is no longer needed.

Export `ct_vars()` such that we can cross-reference it from other functions' documentation.

@rammprasad

As per @rammprasad's suggestion.

Merge branch 'main' into 0046_assign_datetime # Conflicts: # DESCRIPTION # NAMESPACE # NEWS.md # _pkgdown.yml

- This bug is related to the support of input is in two different variables (date and time). - A unit test was also added

Credit goes to @edgar-manukya for the expression

`ct_spec_vars()` used to be an internal function but not anymore: so no need for `:::`.

ramiromagno · 2024-05-14T23:13:35Z

Hi @edgar-manukyan and @rammprasad: I noticed a few typos still lingering... So I decided to go and fix them.

github-actions · 2024-05-14T23:32:02Z

Package	Line Rate	Health
sdtm.oak	72%	➖
Summary	72% (498 / 692)	➖

ramiromagno and others added 30 commits February 8, 2024 02:22

First mockup of hardcode_no_ct()

1c4501f

Update hardcode_no_ct()

faef0b1

Update `hardcode_no_ct()` by allowing the rewriting of the `target_sdtm_variable` variable to preserve `NA`

Align hardcode_no_ct() code style with Ramm's expectations

fd63b37

Add hardcode_*() and assign_*() functions

80d3943

hardcode_no_ct algorithm code changes (#45)

ec5a9e4

* hardcode_no_ct algorithm code changes * harcode_ct working as expected * assign_ct and assign_no_ct works great. * address review comments

Add oak_id_vars()

0333d95

Fix typo in recode()

7fd7716

Simplify oak_id_vars() docs

802aacc

Update assign_* and hardcode_* implementations

7fd07b4

Introduce memoisation of ct_mappings()

9cc26d1

Update of README introductory paragraph

329feaa

Merge from main

29be830

Merge branch 'main' into 0040_hardcode_no_ct # Conflicts: # DESCRIPTION # NAMESPACE # inst/WORDLIST

Update hardcode_* functions' interface

7720c05

Add contains_oak_id_vars() function

e87ca66

Update contains_oak_id_vars() doc examples

a5e61f0

Update sdtm_harcode() and dependant functions

a60ccd6

Update assign_* and hardcore_* related functions

cd89804

Automatic renv profile update.

ae2da80

Automatic renv profile update.

30857e3

Make ct and cl parameters mandatory for assign_ct()

73ebe2d

Add functions ct importing

0eb4677

- Adds three new user facing ct-related functions: `read_ct_example()`, `ct_example()` and `read_ct()` - Provides a ct example file in inst/ct/

Bring hardcode*() and assign*() related assertions closer to user…

dfd7710

… calling functions

Add lagging behind Rd for ct_example()

6652aae

Add assert_ct()

59bcc71

Add ct assertions

7f9f388

Merge branch '0040_hardcode_no_ct' of github.com:pharmaverse/sdtm.oak…

4c81ae1

… into 0040_hardcode_no_ct

Remove R/.gitkeep

4ed5c41

As it is no longer needed.

Add unit tests for ct_vars()

ca26d22

Update dependencies

0456d55

Export ct_vars()

0e1eab4

Export `ct_vars()` such that we can cross-reference it from other functions' documentation.

ramiromagno added 18 commits April 4, 2024 17:43

Add assertions to assign_datetime()

b854a10

Add merge example to assign_datetime() doc

c737310

Style changes

bbbadd3

Style changes (.Rd)

54a6460

Bump version and update news

79e79da

Update ct_map() doc example

42d4d5a

Make tibbles more readable in doc examples

66644eb

Rename ct_cltc to ct_clst

bb2e0d2

As per @rammprasad's suggestion.

Merge branch '0040_hardcode_no_ct' into 0046_assign_datetime

97439f6

Make tibble more readable in assign_datetime() doc examples

73fe395

Merge branch 'main' into 0046_assign_datetime # Conflicts: # DESCRIPTION # NAMESPACE # NEWS.md # _pkgdown.yml

Fix bug in assign_datetime

b17161c

- This bug is related to the support of input is in two different variables (date and time). - A unit test was also added

Linting

3dba6d9

Update styling

04254ac

Add example with date and time to assign_datetime() docs

391df0a

Avoid backslash hell (մերսի)

372f147

Credit goes to @edgar-manukya for the expression

Update ct_spec_vars() docs' examples

6801222

`ct_spec_vars()` used to be an internal function but not anymore: so no need for `:::`.

Fix typo in assign_datetime() documentation

994012b

Fix typo in ct_map() docs

1230e7c

Merge branch 'main' into 0046_assign_datetime

ed9a24d

ramiromagno self-assigned this May 14, 2024

ramiromagno requested review from edgar-manukyan and rammprasad and removed request for edgar-manukyan May 14, 2024 23:27

edgar-manukyan approved these changes May 15, 2024

View reviewed changes

rammprasad approved these changes May 16, 2024

View reviewed changes

ramiromagno merged commit f9816fb into main May 16, 2024
13 checks passed

ramiromagno deleted the 0046_assign_datetime branch May 16, 2024 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0046 assign datetime #52

0046 assign datetime #52

ramiromagno commented May 14, 2024

ramiromagno commented May 14, 2024

github-actions bot commented May 14, 2024

0046 assign datetime #52

0046 assign datetime #52

Conversation

ramiromagno commented May 14, 2024

ramiromagno commented May 14, 2024

github-actions bot commented May 14, 2024