-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a logomark/logotype #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ramiromagno,
I absolutely love the new logo proposal! The AI-generated watercolor of an oak branch and leaves is stunning, and the inspiration drawn from CDISC's logomark colors for the leaves adds a beautiful touch of continuity and homage. The choice of dark blue for the outline and text, matching CDISC's main color, ties everything together perfectly. It's both nice and simple, exactly as you intended.
I have only one suggestion, aimed at fostering future adaptability. Could we include the R code that generated this image in the repository? I understand the hex might have been created using a project similar to hexSticker. Having the code accessible would allow us to modify elements like the outline color easily if we decide to make changes down the line.
Hi Kamil, Thank you for your nice comments about the logo! I haven't used any R code other than So, if you want, you can just take this logo (see this PR's man/figures/logo.svg), open it in Inkscape and adapt it to your needs. |
Hi @ramiro, Looks great. Can we make it green to match the OAK theme? Also, a simpler leaf will be better. I kind of managed to create this, but couldn't get the sdtm.oak inside the hexagon. |
Should we ask people to vote? lol |
Absolutely! After all this is open source :) |
As discussed in today's meeting I will merge the new logo into main. |
Merge branch 'main' into 0043_logomark # Conflicts: # DESCRIPTION # inst/WORDLIST # man/sdtm.oak-package.Rd
Update the WORDLIST file such that SDTM names mentioned in `derive_study_day()` docs do not raise a NOTE
Not having those two fields agree was generating a warning when running `pkgdown::build_site()`
- The font size was increased from 8 to 9 - A darker blueish color was chosen as per Ramm's suggestion (original suggestion was black but this is very close, and matches the existing color used for the navigation bar for the pkgdown website)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much Ramiro, looks awesome! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments.
@rammprasad : I think all requests have been addressed and we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
New logo proposal. I've used an AI-generated simple watercolor of an oak branch and leaves, and made the leaves' hue inspired on CDISC's logomark colors, namely the colored dots. The dark blue of the outline and of the text is the same of CDISC's main dark blue. I think it looks nice and simple. Let me know your thoughts!