Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a logomark/logotype #44

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Adding a logomark/logotype #44

merged 10 commits into from
Mar 14, 2024

Conversation

ramiromagno
Copy link
Collaborator

New logo proposal. I've used an AI-generated simple watercolor of an oak branch and leaves, and made the leaves' hue inspired on CDISC's logomark colors, namely the colored dots. The dark blue of the outline and of the text is the same of CDISC's main dark blue. I think it looks nice and simple. Let me know your thoughts!

sdtm oak-wo-fonts

@ramiromagno ramiromagno linked an issue Mar 7, 2024 that may be closed by this pull request
@ramiromagno ramiromagno self-assigned this Mar 7, 2024
@ramiromagno ramiromagno added the enhancement New feature or request label Mar 7, 2024
Copy link
Collaborator

@kamilsi kamilsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramiromagno,

I absolutely love the new logo proposal! The AI-generated watercolor of an oak branch and leaves is stunning, and the inspiration drawn from CDISC's logomark colors for the leaves adds a beautiful touch of continuity and homage. The choice of dark blue for the outline and text, matching CDISC's main color, ties everything together perfectly. It's both nice and simple, exactly as you intended.

I have only one suggestion, aimed at fostering future adaptability. Could we include the R code that generated this image in the repository? I understand the hex might have been created using a project similar to hexSticker. Having the code accessible would allow us to modify elements like the outline color easily if we decide to make changes down the line.

@ramiromagno
Copy link
Collaborator Author

ramiromagno commented Mar 11, 2024

Hi Kamil,

Thank you for your nice comments about the logo!

I haven't used any R code other than usethis::use_logo() (to place the logo in the right place). I have a long time ago developed my hex border with the right dimensions that I reuse for any new logo creation. So there isn't any special trick other than opening it in Inkscape and editing the logo to your liking and saving it. Then usethis::use_logo() takes the SVG file and places it where it needs to be.

So, if you want, you can just take this logo (see this PR's man/figures/logo.svg), open it in Inkscape and adapt it to your needs.

@ramiromagno ramiromagno requested a review from kamilsi March 11, 2024 19:16
@rammprasad
Copy link
Collaborator

Hi @ramiro, Looks great. Can we make it green to match the OAK theme? Also, a simpler leaf will be better. I kind of managed to create this, but couldn't get the sdtm.oak inside the hexagon.

My first design

@ramiromagno
Copy link
Collaborator Author

Do you mean something like this?

sdtm oak_ramm

(I still prefer my own version :) )

@rammprasad
Copy link
Collaborator

rammprasad commented Mar 13, 2024

Exactly, this is what I meant. We can even replace the oak leaf with an oak tree-like thing. Same problem in this one as well. I wasn't able to get the sdtm.oak inside the hex.
Designer

@rammprasad
Copy link
Collaborator

Should we ask people to vote? lol

@ramiromagno
Copy link
Collaborator Author

Absolutely! After all this is open source :)

@ramiromagno
Copy link
Collaborator Author

As discussed in today's meeting I will merge the new logo into main.

Merge branch 'main' into 0043_logomark

# Conflicts:
#	DESCRIPTION
#	inst/WORDLIST
#	man/sdtm.oak-package.Rd
Update the WORDLIST file such that SDTM names mentioned in `derive_study_day()` docs do not raise a NOTE
Not having those two fields agree was generating a warning when running `pkgdown::build_site()`
- The font size was increased from 8 to 9
- A darker blueish color was chosen as per Ramm's suggestion (original suggestion was black but this is very close, and matches the existing color used for the navigation bar for the pkgdown website)
Copy link

github-actions bot commented Mar 13, 2024

Code Coverage

Package Line Rate Health
sdtm.oak 86%
Summary 86% (349 / 408)

@ramiromagno ramiromagno dismissed kamilsi’s stale review March 13, 2024 23:12

That are no changes to be made.

Copy link
Collaborator

@edgar-manukyan edgar-manukyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Ramiro, looks awesome! ❤️

README.Rmd Show resolved Hide resolved
Copy link
Collaborator

@rammprasad rammprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments.

README.Rmd Show resolved Hide resolved
@ramiromagno ramiromagno requested a review from rammprasad March 14, 2024 09:43
@ramiromagno
Copy link
Collaborator Author

@rammprasad : I think all requests have been addressed and we can merge this.

Copy link
Collaborator

@rammprasad rammprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@rammprasad rammprasad merged commit 45863c3 into main Mar 14, 2024
15 checks passed
@rammprasad rammprasad deleted the 0043_logomark branch March 14, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Create a logomark/logotype hex
4 participants