-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of hardcode_no_ct()
, hardcode_ct()
, assign_no_ct()
and assign_ct()
#41
Conversation
Update `hardcode_no_ct()` by allowing the rewriting of the `target_sdtm_variable` variable to preserve `NA`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, Ramiro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @ramiromagno, very impressive work and smart reuse of coding logic. 💯 ⭐ ⭐ ⭐
I left few suggestions in the code and more questions for @rammprasad :)
Some items here as well:
- Assertions, just a kind reminder.
- Types of the parameters in the roxygen header, just a kind reminder.
- In the tests can we please have a ct dataset with more than one unique value
of codelist_code? 🙏
hardcode_no_ct()
hardcode_no_ct()
, hardcode_ct()
, assign_no_ct()
and assign_ct()
* hardcode_no_ct algorithm code changes * harcode_ct working as expected * assign_ct and assign_no_ct works great. * address review comments
Merge branch 'main' into 0040_hardcode_no_ct # Conflicts: # DESCRIPTION # NAMESPACE # inst/WORDLIST
… into 0040_hardcode_no_ct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
See tidyverse/tidyverse.org#600 for more details.
- `ct` to `ct_spec` (ct specification) - `cl` to `ct_cltc` (codelist code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works amazing. Minor comments. Ready to merge.
@edgar-manukyan @ShiyuC - Ready for the second review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @ramiromagno for an amazing work. 💯 ⭐ ⭐
Looks good to me and left some nice to have comments and thanks for opening issue #48 to increase the coverage 🙏
Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide
to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the
devel
branch until you have checked off each task.Request Title (Use Edit button in top-right if you need to update)
tidyverse style guide. Run
styler::style_file()
to style R and Rmd filesconsider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide
fully follow the
deprecation guidance?
and families. Refer to the
categorization of functions to tag appropriate keyword/family.
devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. ithas an
@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affectedexamples are displayed correctly and that all new functions occur on the "Reference" page.
lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()