Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of hardcode_no_ct(), hardcode_ct(), assign_no_ct() and assign_ct() #41

Merged
merged 68 commits into from
Apr 10, 2024

Conversation

ramiromagno
Copy link
Collaborator

@ramiromagno ramiromagno commented Feb 8, 2024

Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide

to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull z
    Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the
    tidyverse style guide. Run
    styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should
    consider realistic data scenarios and edge cases, e.g. empty datasets, errors,
    boundary cases etc. - See
    Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you
    fully follow the
    deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords
    and families. Refer to the
    categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the
    NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it
    has an @export tag) or documentation aimed at users (rather than developers)
  • Build oak site pkgdown::build_site() and check that all affected
    examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@ramiromagno ramiromagno linked an issue Feb 8, 2024 that may be closed by this pull request
@ramiromagno ramiromagno self-assigned this Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Code Coverage

Package Line Rate Health
sdtm.oak 68%
Summary 68% (447 / 662)

@ramiromagno ramiromagno added the enhancement New feature or request label Feb 13, 2024
Update `hardcode_no_ct()` by allowing the rewriting of the `target_sdtm_variable` variable to preserve `NA`
Copy link
Collaborator

@rammprasad rammprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, Ramiro.

R/hardcode_no_ct.R Outdated Show resolved Hide resolved
R/hardcode_no_ct.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@edgar-manukyan edgar-manukyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ramiromagno, very impressive work and smart reuse of coding logic. 💯 ⭐ ⭐ ⭐

I left few suggestions in the code and more questions for @rammprasad :)

Some items here as well:

  • Assertions, just a kind reminder.
  • Types of the parameters in the roxygen header, just a kind reminder.
  • In the tests can we please have a ct dataset with more than one unique value
    of codelist_code? 🙏

R/assign.R Outdated Show resolved Hide resolved
R/assign.R Outdated Show resolved Hide resolved
R/ct.R Outdated Show resolved Hide resolved
R/ct.R Outdated Show resolved Hide resolved
R/assign.R Outdated Show resolved Hide resolved
R/assign.R Outdated Show resolved Hide resolved
R/ct.R Show resolved Hide resolved
R/hardcode.R Outdated Show resolved Hide resolved
R/hardcode.R Outdated Show resolved Hide resolved
R/hardcode.R Outdated Show resolved Hide resolved
@ramiromagno ramiromagno changed the title First mockup of hardcode_no_ct() Implementation of hardcode_no_ct(), hardcode_ct(), assign_no_ct() and assign_ct() Mar 12, 2024
rammprasad and others added 4 commits March 13, 2024 10:51
* hardcode_no_ct algorithm code changes

* harcode_ct working as expected

* assign_ct and assign_no_ct works great.

* address review comments
Copy link
Collaborator

@rammprasad rammprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

R/hardcode.R Outdated Show resolved Hide resolved
R/assign.R Outdated Show resolved Hide resolved
R/assign.R Show resolved Hide resolved
@ramiromagno ramiromagno requested a review from rammprasad April 3, 2024 10:34
Copy link
Collaborator

@rammprasad rammprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works amazing. Minor comments. Ready to merge.

R/ct.R Show resolved Hide resolved
R/assign.R Show resolved Hide resolved
@rammprasad
Copy link
Collaborator

@edgar-manukyan @ShiyuC - Ready for the second review.

Copy link
Collaborator

@edgar-manukyan edgar-manukyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @ramiromagno for an amazing work. 💯 ⭐ ⭐

Looks good to me and left some nice to have comments and thanks for opening issue #48 to increase the coverage 🙏

R/ct.R Outdated Show resolved Hide resolved
R/hardcode.R Outdated Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
@ramiromagno ramiromagno merged commit 5fc61af into main Apr 10, 2024
15 checks passed
@ramiromagno ramiromagno deleted the 0040_hardcode_no_ct branch April 10, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
3 participants